You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ueshin <gi...@git.apache.org> on 2017/12/25 06:08:03 UTC

[GitHub] spark pull request #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify err...

GitHub user ueshin opened a pull request:

    https://github.com/apache/spark/pull/20074

    [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error messages to show actual versions.

    ## What changes were proposed in this pull request?
    
    This is a follow-up pr of #20054 modifying error messages for both pandas and pyarrow to show actual versions.
    
    ## How was this patch tested?
    
    Existing tests.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ueshin/apache-spark issues/SPARK-22874_fup1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20074.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20074
    
----
commit 07873d704ce2a14add3e476429a785c793e47aa8
Author: Takuya UESHIN <ue...@...>
Date:   2017-12-25T06:02:38Z

    Modify error messages to show actual versions.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    Thanks for reviewing! merging to master.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    **[Test build #85366 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85366/testReport)** for PR 20074 at commit [`07873d7`](https://github.com/apache/spark/commit/07873d704ce2a14add3e476429a785c793e47aa8).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85367/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify err...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20074


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify err...

Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20074#discussion_r158622968
  
    --- Diff: python/pyspark/sql/utils.py ---
    @@ -118,7 +118,8 @@ def require_minimum_pandas_version():
         from distutils.version import LooseVersion
         import pandas
         if LooseVersion(pandas.__version__) < LooseVersion('0.19.2'):
    -        raise ImportError("Pandas >= 0.19.2 must be installed on calling Python process")
    +        raise ImportError("Pandas >= 0.19.2 must be installed on calling Python process: %s"
    --- End diff --
    
    Sounds good. I'll update them. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85366/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify err...

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20074#discussion_r158622598
  
    --- Diff: python/pyspark/sql/utils.py ---
    @@ -118,7 +118,8 @@ def require_minimum_pandas_version():
         from distutils.version import LooseVersion
         import pandas
         if LooseVersion(pandas.__version__) < LooseVersion('0.19.2'):
    -        raise ImportError("Pandas >= 0.19.2 must be installed on calling Python process")
    +        raise ImportError("Pandas >= 0.19.2 must be installed on calling Python process: %s"
    --- End diff --
    
    Maybe, we could make it a bit better like .. `.. on calling Python process; however, your version was %s.`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    **[Test build #85366 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85366/testReport)** for PR 20074 at commit [`07873d7`](https://github.com/apache/spark/commit/07873d704ce2a14add3e476429a785c793e47aa8).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    **[Test build #85367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85367/testReport)** for PR 20074 at commit [`ec1c92f`](https://github.com/apache/spark/commit/ec1c92f3d5e2cbcf77405768a35bd781cc1f93c0).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #20074: [SPARK-22874][PYSPARK][SQL][FOLLOW-UP] Modify error mess...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20074
  
    **[Test build #85367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85367/testReport)** for PR 20074 at commit [`ec1c92f`](https://github.com/apache/spark/commit/ec1c92f3d5e2cbcf77405768a35bd781cc1f93c0).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org