You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/11 22:27:42 UTC
[jira] [Commented] (ZOOKEEPER-2573) Modify Info.REVISION to adapt
git repo
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965045#comment-15965045 ]
ASF GitHub Bot commented on ZOOKEEPER-2573:
-------------------------------------------
GitHub user hanm opened a pull request:
https://github.com/apache/zookeeper/pull/224
ZOOKEEPER-2573: Introduce a python script that generates flaky tests report.
The script is self explaining, here are some notes:
* The original work is done by Appy at Cloudera HBase team.
* The script is customized to fit ZooKeeper's use cases, in particular ZooKeeper allows duplicate test runs, unlike HBase. For example same test could be run three times, one by the test itself, one by Netty test suite, and one by NIO test suite. Script is updated to account for this factor when processing and analyzing test results.
* There will be an Apache Jenkins job set up to run this script on regular basis and publish results dashboard somewhere publicly accessible. For a preview of the dashboard, see http://home.apache.org/~hanm/dashboard/report.html.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hanm/zookeeper ZOOKEEPER-2573
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit 8ef788a5d38e32b333a08e0cf1bf6a9d7fbaa013
Author: Michael Han <ha...@apache.org>
Date: 2017-04-11T22:21:07Z
ZOOKEEPER-2573: Introduce a python script for generating flaky test report.
----
> Modify Info.REVISION to adapt git repo
> --------------------------------------
>
> Key: ZOOKEEPER-2573
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2573
> Project: ZooKeeper
> Issue Type: Bug
> Components: build, server
> Affects Versions: 3.4.9, 3.5.2
> Reporter: Mohammad Arshad
> Assignee: Edward Ribeiro
> Fix For: 3.4.10, 3.5.3, 3.6.0
>
>
> Modify {{org.apache.zookeeper.version.Info.REVISION}} to store git repo revision
> Currently {{org.apache.zookeeper.version.Info.REVISION}} stores the svn repo revision which is of type int
> But after migrating to git repo the git repo's revision(commit 63f5132716c08b3d8f18993bf98eb46eb42f80fb) can not be stored in this variable.
> So either we should modify this variable to string to introduce new variable to store the git revision and leave the svn revision variable unchanged.
> build.xml, and org.apache.zookeeper.version.util.VerGen also need to be modified.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)