You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shiro.apache.org by GitBox <gi...@apache.org> on 2020/04/09 15:06:47 UTC

[GitHub] [shiro] bdemers commented on a change in pull request #210: [SHIRO-530] INI parser does not properly handled backslashes at end o…

bdemers commented on a change in pull request #210: [SHIRO-530] INI parser does not properly handled backslashes at end o…
URL: https://github.com/apache/shiro/pull/210#discussion_r406273496
 
 

 ##########
 File path: config/core/src/test/groovy/org/apache/shiro/config/IniTest.groovy
 ##########
 @@ -119,24 +135,40 @@ public class IniTest {
         assertEquals("Truth", kv[0]);
         assertEquals("Beauty", kv[1]);
 
+        // Escape characters are to be removed from the key.
+        // This is different behaviour compared to the XML config.
 
 Review comment:
   This seems odd, but I guess it's existing functionality

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services