You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by srgpqt <gi...@git.apache.org> on 2015/10/23 18:03:37 UTC
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
GitHub user srgpqt opened a pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2
Handle opening links in new window
Makes links with target="_blank" behave as expected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cortexmedia/cordova-plugin-wkwebview-engine master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2
----
commit f495e8292b0131c446f354198654b5b7e435c7ca
Author: Serge Paquet <sp...@cortex.bz>
Date: 2015-10-23T15:59:19Z
Handle opening links in new window
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Posted by rayshan <gi...@git.apache.org>.
Github user rayshan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175785833
Thanks. By "new window", do you mean links are opening in Safari as a new tab when you use `target="_blank"`?
FYI We've been using https://github.com/apache/cordova-plugin-inappbrowser and `window.open` to open links in the in-app-browser.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Posted by srgpqt <gi...@git.apache.org>.
Github user srgpqt commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175781426
target="_blank" worked for me in the iOS 9.2 simulator. I'll do some more testing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Posted by rayshan <gi...@git.apache.org>.
Github user rayshan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175756155
Hi @srgpqt, why is it no longer relevant? Seems like we still have to do `window.open` instead of `target="_blank"`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Posted by srgpqt <gi...@git.apache.org>.
Github user srgpqt closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Posted by rayshan <gi...@git.apache.org>.
Github user rayshan commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175819620
Thanks for the confirmation! We'll try this as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Posted by srgpqt <gi...@git.apache.org>.
Github user srgpqt commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175738375
No longer relevant.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-wkwebview-engine pull request: Handle opening links...
Posted by srgpqt <gi...@git.apache.org>.
Github user srgpqt commented on the pull request:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/2#issuecomment-175787574
Yes, links are opening in Safari as a new tab when I use target="_blank" on <a> elements.
I'm not using the InAppBrowser plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org