You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/12/09 02:27:51 UTC

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #1530: [KYUUBI #1528] Record the kyuubi server ip address in event log

wForget commented on a change in pull request #1530:
URL: https://github.com/apache/incubator-kyuubi/pull/1530#discussion_r765387478



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSessionImpl.scala
##########
@@ -53,6 +54,7 @@ class SparkSessionImpl(
       case (key, value) => setModifiableConfig(key, value)
     }
     KDFRegistry.registerAll(spark)
+    sessionEvent.serverIp = serverIpAddress

Review comment:
       > inside `SessionEvent.apply`
   
   change `SessionEvent.apply(session: Session)` to `SessionEvent.apply(session: SparkSessionImpl)`, or use `session.asInstanceOf[SparkSessionImpl].serverIpAddress` in SessionEvent, which one is better?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org