You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Juan Yu (Code Review)" <ge...@cloudera.org> on 2016/10/07 22:06:02 UTC
[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Juan Yu has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4668
Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
......................................................................
IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Fixed double decrement in case a cached connection is broken
and cannot be re-created.
Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
---
M be/src/runtime/client-cache.cc
1 file changed, 6 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/4668/1
--
To view, visit http://gerrit.cloudera.org:8080/4668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Juan Yu <jy...@cloudera.com>
[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Posted by "Juan Yu (Code Review)" <ge...@cloudera.org>.
Hello Sailesh Mukil, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/4668
to look at the new patch set (#2).
Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
......................................................................
IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Fixed double decrement in case a cached connection is broken
and cannot be re-created.
Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
---
M be/src/runtime/client-cache.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/68/4668/2
--
To view, visit http://gerrit.cloudera.org:8080/4668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Posted by "Juan Yu (Code Review)" <ge...@cloudera.org>.
Juan Yu has posted comments on this change.
Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Carry Dan's +2
http://gerrit.cloudera.org:8080/#/c/4668/1/be/src/runtime/client-cache.cc
File be/src/runtime/client-cache.cc:
PS1, Line 95: if (metrics_enabled_) {
> the "if succeeded" explains this, so you could remove this sentence, which
Done
--
To view, visit http://gerrit.cloudera.org:8080/4668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/4668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
......................................................................
IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Fixed double decrement in case a cached connection is broken
and cannot be re-created.
Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
Reviewed-on: http://gerrit.cloudera.org:8080/4668
Reviewed-by: Juan Yu <jy...@cloudera.com>
Tested-by: Internal Jenkins
---
M be/src/runtime/client-cache.cc
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Juan Yu: Looks good to me, approved
Internal Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Posted by "Dan Hecht (Code Review)" <ge...@cloudera.org>.
Dan Hecht has posted comments on this change.
Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4668/1/be/src/runtime/client-cache.cc
File be/src/runtime/client-cache.cc:
PS1, Line 95: // Only need to decrement it here.
the "if succeeded" explains this, so you could remove this sentence, which I think is a bit confusing (not clear what "here" means -- this function, this if-stmt, etc?).
--
To view, visit http://gerrit.cloudera.org:8080/4668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
Posted by "Sailesh Mukil (Code Review)" <ge...@cloudera.org>.
Sailesh Mukil has posted comments on this change.
Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/4668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9e28055cb232cdb543c4c9f05a558ab0f73f777
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-HasComments: No