You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "yuqian90 (via GitHub)" <gi...@apache.org> on 2023/03/08 07:57:32 UTC
[GitHub] [airflow] yuqian90 opened a new pull request, #29971: Fix some long know Graph View UI problems
yuqian90 opened a new pull request, #29971:
URL: https://github.com/apache/airflow/pull/29971
We often hear these two complaints from users:
1. Graph View does not make use of the whole screen space. The height is clipped at a fixed value. This is especially bad for large monitors.
2. Graph jumps around when TaskGroup is expanded or collapsed
This PR fixes both issues.
Here's a gif showing some of the UI interactions after this change. Notice these two changes:
1. The graph now uses the whole page. It's no longer clipped to a fixed height
2. The clicked node focuses around the cursor when TaskGroup is expanded or collapsed, instead of jumping around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #29971: Fix some long known Graph View UI problems
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #29971:
URL: https://github.com/apache/airflow/pull/29971#issuecomment-1460720582
Also, the new graph view doesn't have the first problem. But I'll make sure the second problem is also addressed before 2.6.0 is released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #29971: Fix some long known Graph View UI problems
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #29971:
URL: https://github.com/apache/airflow/pull/29971#issuecomment-1469250602
@yuqian90 wdyt of expand/collapse like this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yuqian90 commented on pull request #29971: Fix some long known Graph View UI problems
Posted by "yuqian90 (via GitHub)" <gi...@apache.org>.
yuqian90 commented on PR #29971:
URL: https://github.com/apache/airflow/pull/29971#issuecomment-1461062774
> Looking good. Do you mind running `yarn && yarn lint` in the `airflow/www` directory? Static checks aren't happy.
Thanks for pointing out. Done. It did uncover an unused variable.
> Also, the new graph view doesn't have the first problem. But I'll make sure the second problem is also addressed before 2.6.0 is released.
That sounds great. Is there a place to preview what 2.6.0 graph will look like?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #29971: Fix some long known Graph View UI problems
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #29971:
URL: https://github.com/apache/airflow/pull/29971#issuecomment-1461067282
> That sounds great. Is there a place to preview what 2.6.0 graph will look like?
Either run airflow locally, or you can see some screenshots/gifs in the PR: https://github.com/apache/airflow/pull/29413
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #29971: Fix some long known Graph View UI problems
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #29971:
URL: https://github.com/apache/airflow/pull/29971#issuecomment-1460451852
Looking good. Do you mind running `yarn && yarn lint` in the `airflow/www` directory? Static checks aren't happy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #29971: Fix some long known Graph View UI problems
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi merged PR #29971:
URL: https://github.com/apache/airflow/pull/29971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] yuqian90 commented on pull request #29971: Fix some long known Graph View UI problems
Posted by "yuqian90 (via GitHub)" <gi...@apache.org>.
yuqian90 commented on PR #29971:
URL: https://github.com/apache/airflow/pull/29971#issuecomment-1471208053
> @yuqian90 wdyt of expand/collapse like this?
>
>  [  ](https://user-images.githubusercontent.com/4600967/225196637-1d5cfb12-083f-42bb-842e-8ef152d25578.gif) [ ](https://user-images.githubusercontent.com/4600967/225196637-1d5cfb12-083f-42bb-842e-8ef152d25578.gif)
This looks awesome. Does it scale well with large DAGs? e.g. one that has hundreds of tasks and many TaskGroups?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi commented on pull request #29971: Fix some long known Graph View UI problems
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #29971:
URL: https://github.com/apache/airflow/pull/29971#issuecomment-1474097087
> This looks awesome. Does it scale well with large DAGs? e.g. one that has hundreds of tasks and many TaskGroups?
Working on it! If not, maybe we'll just disable animations if there are 1000+ tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org