You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/10/05 22:48:42 UTC

[GitHub] [druid] suneet-s commented on a change in pull request #10481: Imply 4723

suneet-s commented on a change in pull request #10481:
URL: https://github.com/apache/druid/pull/10481#discussion_r499913299



##########
File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java
##########
@@ -142,7 +143,7 @@
       .add("is_available", ValueType.LONG)
       .add("is_realtime", ValueType.LONG)
       .add("is_overshadowed", ValueType.LONG)
-      .add("shardSpec", ValueType.STRING)
+      .add("shard_spec", ValueType.STRING)

Review comment:
       `shardSpec` was introduced in this change https://github.com/apache/druid/pull/9883 and changing it to `shard_spec` would be a breaking change. I don't think we should do this without an upgrade plan




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org