You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by notona <gi...@git.apache.org> on 2015/07/04 11:55:19 UTC

[GitHub] thrift pull request: dont' create @Generated annotation when using...

GitHub user notona opened a pull request:

    https://github.com/apache/thrift/pull/540

    dont' create @Generated annotation when using with java:android option

    Generated Java RPC Client Code is using @Generated Annotation. 
    But Android does not support @Generated Annotation.
    so i think, thrift dont' have to create @Generated Annotation when using thrift command with java:android option
    
    here is the issue.
    https://issues.apache.org/jira/browse/THRIFT-3220

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/notona/thrift generated_annotation_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #540
    
----
commit 2713ce852d29e00c1dcfe49ca7979925e37dbd9a
Author: notona <no...@gmail.com>
Date:   2015-07-04T09:50:19Z

    dont' create @Generated annotation when using with java:android option

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3220: dont' create @Generated annotati...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/540


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---