You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Robert Kühne (Created JIRA)" <ji...@apache.org> on 2012/02/09 19:11:59 UTC
[jira] [Created] (WICKET-4401) Redirect after sign in with
SignInPanel does not always reach homepage
Redirect after sign in with SignInPanel does not always reach homepage
----------------------------------------------------------------------
Key: WICKET-4401
URL: https://issues.apache.org/jira/browse/WICKET-4401
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.5.4
Reporter: Robert Kühne
Attachments: login.zip
Im using SingInPanel for login and lately I observed some weird behaviour which I initially couldn't reproduce. It seems that the redirect which is happening after the login sometimes fails and I finally managed to build a quickstart. The bug does only show up when using tomcat (6.0.29) and not in jetty. I guess it is because of the context path which is not used in jetty in the default configuration. The quickstart eclipse project is named "login" which results in the context path you see below.
Do the following to see the bug:
- Clear all your cookies for localhost.
- Open http://localhost:8080/login/user/login
- Login in with whatever you like, it accepts everything.
- You will be redirected to something like http://localhost:8080/login/user/..;jsessionid=6BA0D67319631289F84008F699B07341
which shows the text "TestPage" which is not the homepage but should be. The class TestPage showing this text is mapped to /user
- If you want to go further you can open http://localhost:8080/login/user/login again and login in again you will be redirected to http://localhost:8080/login/
I dug around the request cycle which didn't help too much. Another guess is that the MountedMapper might do something bad here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (WICKET-4401) Redirect after sign in with
SignInPanel does not always reach homepage
Posted by "Martin Grigorov (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4401.
-------------------------------------
Resolution: Fixed
Fix Version/s: 6.0.0
1.5.5
Assignee: Martin Grigorov
> Redirect after sign in with SignInPanel does not always reach homepage
> ----------------------------------------------------------------------
>
> Key: WICKET-4401
> URL: https://issues.apache.org/jira/browse/WICKET-4401
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Robert Kühne
> Assignee: Martin Grigorov
> Fix For: 1.5.5, 6.0.0
>
> Attachments: WICKET-4401.patch, WICKET-4401.patch, login.zip
>
>
> Im using SingInPanel for login and lately I observed some weird behaviour which I initially couldn't reproduce. It seems that the redirect which is happening after the login sometimes fails and I finally managed to build a quickstart. The bug does only show up when using tomcat (6.0.29) and not in jetty. I guess it is because of the context path which is not used in jetty in the default configuration. The quickstart eclipse project is named "login" which results in the context path you see below.
> Do the following to see the bug:
> - Clear all your cookies for localhost.
> - Open http://localhost:8080/login/user/login
> - Login in with whatever you like, it accepts everything.
> - You will be redirected to something like http://localhost:8080/login/user/..;jsessionid=6BA0D67319631289F84008F699B07341
> which shows the text "TestPage" which is not the homepage but should be. The class TestPage showing this text is mapped to /user
> - If you want to go further you can open http://localhost:8080/login/user/login again and login in again you will be redirected to http://localhost:8080/login/
> I dug around the request cycle which didn't help too much. Another guess is that the MountedMapper might do something bad here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4401) Redirect after sign in with
SignInPanel does not always reach homepage
Posted by "Robert Kühne (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211989#comment-13211989 ]
Robert Kühne commented on WICKET-4401:
--------------------------------------
I tested the patch and can confirm that it works for me, too.
> Redirect after sign in with SignInPanel does not always reach homepage
> ----------------------------------------------------------------------
>
> Key: WICKET-4401
> URL: https://issues.apache.org/jira/browse/WICKET-4401
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Robert Kühne
> Attachments: WICKET-4401.patch, login.zip
>
>
> Im using SingInPanel for login and lately I observed some weird behaviour which I initially couldn't reproduce. It seems that the redirect which is happening after the login sometimes fails and I finally managed to build a quickstart. The bug does only show up when using tomcat (6.0.29) and not in jetty. I guess it is because of the context path which is not used in jetty in the default configuration. The quickstart eclipse project is named "login" which results in the context path you see below.
> Do the following to see the bug:
> - Clear all your cookies for localhost.
> - Open http://localhost:8080/login/user/login
> - Login in with whatever you like, it accepts everything.
> - You will be redirected to something like http://localhost:8080/login/user/..;jsessionid=6BA0D67319631289F84008F699B07341
> which shows the text "TestPage" which is not the homepage but should be. The class TestPage showing this text is mapped to /user
> - If you want to go further you can open http://localhost:8080/login/user/login again and login in again you will be redirected to http://localhost:8080/login/
> I dug around the request cycle which didn't help too much. Another guess is that the MountedMapper might do something bad here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4401) Redirect after sign in with
SignInPanel does not always reach homepage
Posted by "Robert Kühne (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207815#comment-13207815 ]
Robert Kühne commented on WICKET-4401:
--------------------------------------
Unmounting the login page (comment out mountPage("/user/login", LoginPage.class) in WicketApplication) seems to solve the issue as a workaround. Though, the nice mount is gone and you have to use: http://localhost:8080/login/wicket/bookmarkable/de.rob.login.LoginPage
This seems to back the theory of a broken MountedMapper (or related code).
> Redirect after sign in with SignInPanel does not always reach homepage
> ----------------------------------------------------------------------
>
> Key: WICKET-4401
> URL: https://issues.apache.org/jira/browse/WICKET-4401
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Robert Kühne
> Attachments: login.zip
>
>
> Im using SingInPanel for login and lately I observed some weird behaviour which I initially couldn't reproduce. It seems that the redirect which is happening after the login sometimes fails and I finally managed to build a quickstart. The bug does only show up when using tomcat (6.0.29) and not in jetty. I guess it is because of the context path which is not used in jetty in the default configuration. The quickstart eclipse project is named "login" which results in the context path you see below.
> Do the following to see the bug:
> - Clear all your cookies for localhost.
> - Open http://localhost:8080/login/user/login
> - Login in with whatever you like, it accepts everything.
> - You will be redirected to something like http://localhost:8080/login/user/..;jsessionid=6BA0D67319631289F84008F699B07341
> which shows the text "TestPage" which is not the homepage but should be. The class TestPage showing this text is mapped to /user
> - If you want to go further you can open http://localhost:8080/login/user/login again and login in again you will be redirected to http://localhost:8080/login/
> I dug around the request cycle which didn't help too much. Another guess is that the MountedMapper might do something bad here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4401) Redirect after sign in with
SignInPanel does not always reach homepage
Posted by "Robert Kühne (Updated JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Kühne updated WICKET-4401:
---------------------------------
Attachment: login.zip
quickstart
> Redirect after sign in with SignInPanel does not always reach homepage
> ----------------------------------------------------------------------
>
> Key: WICKET-4401
> URL: https://issues.apache.org/jira/browse/WICKET-4401
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Robert Kühne
> Attachments: login.zip
>
>
> Im using SingInPanel for login and lately I observed some weird behaviour which I initially couldn't reproduce. It seems that the redirect which is happening after the login sometimes fails and I finally managed to build a quickstart. The bug does only show up when using tomcat (6.0.29) and not in jetty. I guess it is because of the context path which is not used in jetty in the default configuration. The quickstart eclipse project is named "login" which results in the context path you see below.
> Do the following to see the bug:
> - Clear all your cookies for localhost.
> - Open http://localhost:8080/login/user/login
> - Login in with whatever you like, it accepts everything.
> - You will be redirected to something like http://localhost:8080/login/user/..;jsessionid=6BA0D67319631289F84008F699B07341
> which shows the text "TestPage" which is not the homepage but should be. The class TestPage showing this text is mapped to /user
> - If you want to go further you can open http://localhost:8080/login/user/login again and login in again you will be redirected to http://localhost:8080/login/
> I dug around the request cycle which didn't help too much. Another guess is that the MountedMapper might do something bad here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4401) Redirect after sign in with
SignInPanel does not always reach homepage
Posted by "Martin Grigorov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4401:
------------------------------------
Attachment: WICKET-4401.patch
Here is another patch which I believe is better.
> Redirect after sign in with SignInPanel does not always reach homepage
> ----------------------------------------------------------------------
>
> Key: WICKET-4401
> URL: https://issues.apache.org/jira/browse/WICKET-4401
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Robert Kühne
> Attachments: WICKET-4401.patch, WICKET-4401.patch, login.zip
>
>
> Im using SingInPanel for login and lately I observed some weird behaviour which I initially couldn't reproduce. It seems that the redirect which is happening after the login sometimes fails and I finally managed to build a quickstart. The bug does only show up when using tomcat (6.0.29) and not in jetty. I guess it is because of the context path which is not used in jetty in the default configuration. The quickstart eclipse project is named "login" which results in the context path you see below.
> Do the following to see the bug:
> - Clear all your cookies for localhost.
> - Open http://localhost:8080/login/user/login
> - Login in with whatever you like, it accepts everything.
> - You will be redirected to something like http://localhost:8080/login/user/..;jsessionid=6BA0D67319631289F84008F699B07341
> which shows the text "TestPage" which is not the homepage but should be. The class TestPage showing this text is mapped to /user
> - If you want to go further you can open http://localhost:8080/login/user/login again and login in again you will be redirected to http://localhost:8080/login/
> I dug around the request cycle which didn't help too much. Another guess is that the MountedMapper might do something bad here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WICKET-4401) Redirect after sign in with
SignInPanel does not always reach homepage
Posted by "Bartosz Jakubowski (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214866#comment-13214866 ]
Bartosz Jakubowski commented on WICKET-4401:
--------------------------------------------
I'm using Jetty 6.1.26 and had the same issue. Patch works for me also.
> Redirect after sign in with SignInPanel does not always reach homepage
> ----------------------------------------------------------------------
>
> Key: WICKET-4401
> URL: https://issues.apache.org/jira/browse/WICKET-4401
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Robert Kühne
> Attachments: WICKET-4401.patch, WICKET-4401.patch, login.zip
>
>
> Im using SingInPanel for login and lately I observed some weird behaviour which I initially couldn't reproduce. It seems that the redirect which is happening after the login sometimes fails and I finally managed to build a quickstart. The bug does only show up when using tomcat (6.0.29) and not in jetty. I guess it is because of the context path which is not used in jetty in the default configuration. The quickstart eclipse project is named "login" which results in the context path you see below.
> Do the following to see the bug:
> - Clear all your cookies for localhost.
> - Open http://localhost:8080/login/user/login
> - Login in with whatever you like, it accepts everything.
> - You will be redirected to something like http://localhost:8080/login/user/..;jsessionid=6BA0D67319631289F84008F699B07341
> which shows the text "TestPage" which is not the homepage but should be. The class TestPage showing this text is mapped to /user
> - If you want to go further you can open http://localhost:8080/login/user/login again and login in again you will be redirected to http://localhost:8080/login/
> I dug around the request cycle which didn't help too much. Another guess is that the MountedMapper might do something bad here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WICKET-4401) Redirect after sign in with
SignInPanel does not always reach homepage
Posted by "Martin Grigorov (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-4401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-4401:
------------------------------------
Attachment: WICKET-4401.patch
I think it is related to how Tomcat's handles urls which end with '..'.
This patch appends '/' if the url ends with '..' and seems to solve the problem.
> Redirect after sign in with SignInPanel does not always reach homepage
> ----------------------------------------------------------------------
>
> Key: WICKET-4401
> URL: https://issues.apache.org/jira/browse/WICKET-4401
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.4
> Reporter: Robert Kühne
> Attachments: WICKET-4401.patch, login.zip
>
>
> Im using SingInPanel for login and lately I observed some weird behaviour which I initially couldn't reproduce. It seems that the redirect which is happening after the login sometimes fails and I finally managed to build a quickstart. The bug does only show up when using tomcat (6.0.29) and not in jetty. I guess it is because of the context path which is not used in jetty in the default configuration. The quickstart eclipse project is named "login" which results in the context path you see below.
> Do the following to see the bug:
> - Clear all your cookies for localhost.
> - Open http://localhost:8080/login/user/login
> - Login in with whatever you like, it accepts everything.
> - You will be redirected to something like http://localhost:8080/login/user/..;jsessionid=6BA0D67319631289F84008F699B07341
> which shows the text "TestPage" which is not the homepage but should be. The class TestPage showing this text is mapped to /user
> - If you want to go further you can open http://localhost:8080/login/user/login again and login in again you will be redirected to http://localhost:8080/login/
> I dug around the request cycle which didn't help too much. Another guess is that the MountedMapper might do something bad here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira