You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/29 10:21:10 UTC

[GitHub] [superset] geido commented on pull request #15925: fix: Cancel alert is not appearing to all native filters modal fields

geido commented on pull request #15925:
URL: https://github.com/apache/superset/pull/15925#issuecomment-888995991


   Hello @michael-s-molina. Thanks for the fix.
   
   I have noticed that when changing an existing filter and then creating a new one, when saving it says "1 unsaved filter". However, I would expect that to say "2 unsaved filters" as I did changes to two filters that were not saved yet. This is a minor thing though.
   
   https://user-images.githubusercontent.com/60598000/127475314-d7edaf6f-a2a0-430e-9ef5-03268f0d721c.mp4
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org