You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by AsterixDB Code Review <do...@asterix-gerrit.ics.uci.edu> on 2022/12/05 20:27:17 UTC

Change in asterixdb[master]: [NO ISSUE][RT] Introducing the JSON Edit Distance (JEDI).

From Wail Alkowaileet <wa...@gmail.com>:

Attention is currently required from: Ian Maxon, Thomas Hütter.
Wail Alkowaileet has posted comments on this change. ( https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16323 )

Change subject: [NO ISSUE][RT] Introducing the JSON Edit Distance (JEDI).
......................................................................


Patch Set 14:

(2 comments)

File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/common/JSONTreeTransformator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16323/comment/eb3b719b_1c4b1948 
PS14, Line 38: JSONTreeTransformator
Let's move the logic of JSONTreeVisitor to the evaluator and remove this class.


File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/JEDIEvaluator.java:

https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16323/comment/e305e1c4_0a808b69 
PS10, Line 80: double
Private? Also for the one below



-- 
To view, visit https://asterix-gerrit.ics.uci.edu/c/asterixdb/+/16323
To unsubscribe, or for help writing mail filters, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Change-Id: Icd8ab08629191c406f08c02ceed80c4856261c1c
Gerrit-Change-Number: 16323
Gerrit-PatchSet: 14
Gerrit-Owner: Thomas Hütter <th...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <im...@uci.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Wail Alkowaileet <wa...@gmail.com>
Gerrit-CC: Till Westmann <ti...@apache.org>
Gerrit-Attention: Ian Maxon <im...@uci.edu>
Gerrit-Attention: Thomas Hütter <th...@gmail.com>
Gerrit-Comment-Date: Mon, 05 Dec 2022 20:27:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment