You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/21 22:00:26 UTC
[GitHub] [flink] afedulov opened a new pull request, #20876: [hotfix][docs] Fix typo in Kinesis Connector docs.
afedulov opened a new pull request, #20876:
URL: https://github.com/apache/flink/pull/20876
This is a trivial docs fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer commented on a diff in pull request #20876: [hotfix][docs] Fix typos in Kinesis Connector docs.
Posted by GitBox <gi...@apache.org>.
dannycranmer commented on code in PR #20876:
URL: https://github.com/apache/flink/pull/20876#discussion_r978417586
##########
docs/content.zh/docs/connectors/table/kinesis.md:
##########
@@ -776,7 +776,7 @@ You can enable and configure EFO with the following properties:
This is the preferred strategy for the majority of applications.
However, jobs with parallelism greater than 1 will result in tasks competing to register and acquire the stream consumer ARN.
For jobs with very large parallelism this can result in an increased start-up time.
- The describe operation has a limit of 20 [transactions per second](https://docs.aws.amazon.com/kinesis/latest/APIReference/API_DescribeStreamConsumer.html),
Review Comment:
I think this is intentional, the API is called `DescribeStreamConsumer`, could be more explicit and change to
> The `DescribeStreamConsumer` operation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dannycranmer merged pull request #20876: [hotfix][docs] Fix typos in Kinesis Connector docs.
Posted by GitBox <gi...@apache.org>.
dannycranmer merged PR #20876:
URL: https://github.com/apache/flink/pull/20876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #20876: [hotfix][docs] Fix typo in Kinesis Connector docs.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20876:
URL: https://github.com/apache/flink/pull/20876#issuecomment-1254277324
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "417ffb9e3b582ebc1c5741d04876f1ab33ab4b61",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "417ffb9e3b582ebc1c5741d04876f1ab33ab4b61",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 417ffb9e3b582ebc1c5741d04876f1ab33ab4b61 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on a diff in pull request #20876: [hotfix][docs] Fix typos in Kinesis Connector docs.
Posted by GitBox <gi...@apache.org>.
afedulov commented on code in PR #20876:
URL: https://github.com/apache/flink/pull/20876#discussion_r978609413
##########
docs/content.zh/docs/connectors/table/kinesis.md:
##########
@@ -776,7 +776,7 @@ You can enable and configure EFO with the following properties:
This is the preferred strategy for the majority of applications.
However, jobs with parallelism greater than 1 will result in tasks competing to register and acquire the stream consumer ARN.
For jobs with very large parallelism this can result in an increased start-up time.
- The describe operation has a limit of 20 [transactions per second](https://docs.aws.amazon.com/kinesis/latest/APIReference/API_DescribeStreamConsumer.html),
Review Comment:
Ah, ok, that makes sense, updated accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org