[GitHub] [druid] jihoonson commented on a change in pull request #11019: Auto-compaction with segment granularity retrieve incomplete segments from timeline when interval overlap

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #11019:
URL: https://github.com/apache/druid/pull/11019#discussion_r600078907



##########
File path: server/src/main/java/org/apache/druid/server/coordinator/duty/NewestSegmentFirstIterator.java
##########
@@ -249,14 +246,13 @@ private void updateQueue(String dataSourceName, DataSourceCompactionConfig confi
   private static class CompactibleTimelineObjectHolderCursor implements Iterator<List<DataSegment>>
   {
     private final List<TimelineObjectHolder<String, DataSegment>> holders;
-    private final Map<Pair<Interval, SegmentId>, ShardSpec> originalShardSpecs;
-    private final Map<Pair<Interval, SegmentId>, String> originalVersion;
+    private final VersionedIntervalTimeline<String, DataSegment> originalTimeline;

Review comment:
       Please add `@Nullable` here too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org