You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/02/20 05:31:59 UTC

[GitHub] [hadoop-ozone] swagle opened a new pull request #570: HDDS-3035. Add ability to enable Ratis metrics in OzoneManager.

swagle opened a new pull request #570: HDDS-3035. Add ability to enable Ratis metrics in OzoneManager.
URL: https://github.com/apache/hadoop-ozone/pull/570
 
 
   ## What changes were proposed in this pull request?
   Enabled Dropwizard metrics registry to publish all OM Ratis metrics to JMX and configured metrics system endpoint.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-3035
   
   ## How was this patch tested?
   1. Added an integration test 
   2. Verified using docker build
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx merged pull request #570: HDDS-3035. Add ability to enable Ratis metrics in OzoneManager.

Posted by GitBox <gi...@apache.org>.
avijayanhwx merged pull request #570: HDDS-3035. Add ability to enable Ratis metrics in OzoneManager.
URL: https://github.com/apache/hadoop-ozone/pull/570
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on a change in pull request #570: HDDS-3035. Add ability to enable Ratis metrics in OzoneManager.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on a change in pull request #570: HDDS-3035. Add ability to enable Ratis metrics in OzoneManager.
URL: https://github.com/apache/hadoop-ozone/pull/570#discussion_r382840418
 
 

 ##########
 File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
 ##########
 @@ -1068,14 +1074,20 @@ public OMMetrics getMetrics() {
    * Start service.
    */
   public void start() throws IOException {
-
     omClientProtocolMetrics.register();
+    HddsServerUtil.initializeMetrics(configuration, "OzoneManager");
 
 Review comment:
   One comment. We can probably add ratis reporters only if Ratis is enabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] avijayanhwx commented on issue #570: HDDS-3035. Add ability to enable Ratis metrics in OzoneManager.

Posted by GitBox <gi...@apache.org>.
avijayanhwx commented on issue #570: HDDS-3035. Add ability to enable Ratis metrics in OzoneManager.
URL: https://github.com/apache/hadoop-ozone/pull/570#issuecomment-589918985
 
 
   Thank you for the fix @swagle. I am OK with merging it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org