[GitHub] [pulsar] 315157973 commented on a diff in pull request #20397: [improve][broker] Create non-partitioned system topics in auto topic creation

["315157973 (via GitHub)" <gi...@apache.org>]

315157973 commented on code in PR #20397:
URL: https://github.com/apache/pulsar/pull/20397#discussion_r1205256503


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -3319,6 +3319,12 @@ private CompletableFuture<Boolean> isAllowAutoTopicCreationAsync(final TopicName
     }
 
     public boolean isDefaultTopicTypePartitioned(final TopicName topicName, final Optional<Policies> policies) {
+        // system topics should be non-partitioned by default regardless of the broker config
+        // allowAutoTopicCreationType setting
+        if (SystemTopicNames.isSystemTopic(topicName)
+                || NamespaceService.isSystemServiceNamespace(topicName.getNamespace())) {
+            return false;
+        }

Review Comment:
   Why must it be non-partitioned?
   
   Should it be configurable?
   
   Should this be discussed in the mail list?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org