You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ben Laurie <be...@algroup.co.uk> on 2001/04/25 18:53:39 UTC
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
orlikowski@apache.org wrote:
>
> orlikowski 01/04/23 19:50:19
>
> Modified: module-2.0 proxy_util.c
> Log:
> Just for the sake of cleanliness ...
??? this patch changes what is passed from NULL to the address of a
variable set to zero - is that intended?
Cheers,
Ben.
>
> Revision Changes Path
> 1.56 +2 -1 httpd-proxy/module-2.0/proxy_util.c
>
> Index: proxy_util.c
> ===================================================================
> RCS file: /home/cvs/httpd-proxy/module-2.0/proxy_util.c,v
> retrieving revision 1.55
> retrieving revision 1.56
> diff -u -r1.55 -r1.56
> --- proxy_util.c 2001/04/23 21:03:39 1.55
> +++ proxy_util.c 2001/04/24 02:50:19 1.56
> @@ -1087,6 +1087,7 @@
> {
> apr_bucket *e;
> apr_status_t rv;
> + apr_size_t zero = 0;
> char *pos = buff;
> char *response;
> int found = 0;
> @@ -1100,7 +1101,7 @@
> while (!found) {
>
> /* get brigade from network one line at a time */
> - if (APR_SUCCESS != (rv = ap_get_brigade(c->input_filters, bb, AP_MODE_BLOCKING, 0))) {
> + if (APR_SUCCESS != (rv = ap_get_brigade(c->input_filters, bb, AP_MODE_BLOCKING, &zero))) {
> return rv;
> }
>
>
>
>
--
http://www.apache-ssl.org/ben.html
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
ApacheCon 2001! http://ApacheCon.com/
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by "Victor J. Orlikowski" <v....@gte.net>.
> quoting relevant text is just the right thing to do....
OK. I'll remember my etiquette in the future.
(Perhaps I should re-read Emily Postnews ... :)
Victor
--
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
orlikowski@apache.org
vjo@us.ibm.com
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by Jim Winstead <ji...@trainedmonkey.com>.
On Wed, Apr 25, 2001 at 03:44:03PM -0400, Victor J. Orlikowski wrote:
> Fine.
> I'll reply with previous messages attached in the future.
> Question: you do use a threading mail reader, yes?
it doesn't matter if you use a threading mail reader when
you delete messages as you read them, and read them often.
quoting relevant text is just the right thing to do....
jim
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by Ben Laurie <be...@algroup.co.uk>.
Greg Stein wrote:
> I use Mutt, and yes: it can thread. But I don't do that. I read mail in
> received-order. Pisses me off when a new mail appears buried in some thread
> somewhere.
The way I deal with this is to read threaded first, and then what's left
in received order.
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
ApacheCon 2001! http://ApacheCon.com/
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by Greg Stein <gs...@lyra.org>.
On Wed, Apr 25, 2001 at 03:44:03PM -0400, Victor J. Orlikowski wrote:
> Fine.
> I'll reply with previous messages attached in the future.
> Question: you do use a threading mail reader, yes?
As Jim mentioned, that supposition doesn't work when you delete emails
rapidly. And even if so, what about people that don't have threading
readers? Or maybe they don't use the threading in their mail reader?
I use Mutt, and yes: it can thread. But I don't do that. I read mail in
received-order. Pisses me off when a new mail appears buried in some thread
somewhere.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by "Victor J. Orlikowski" <v....@gte.net>.
Fine.
I'll reply with previous messages attached in the future.
Question: you do use a threading mail reader, yes?
Victor
Greg Stein writes:
> CONTEXT!!
>
> On Wed, Apr 25, 2001 at 01:05:52PM -0400, Victor J. Orlikowski wrote:
> > I believe so, Ben.
> > If I understand the readbytes bit correctly, it is a pointer to a
> > value containing the *amount* to read, where 0 is line-at-a-time.
> >
> > Victor
> > --
> > Victor J. Orlikowski
> > ======================
> > v.j.orlikowski@gte.net
> > orlikowski@apache.org
> > vjo@us.ibm.com
>
> --
> Greg Stein, http://www.lyra.org/
--
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
orlikowski@apache.org
vjo@us.ibm.com
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by Greg Stein <gs...@lyra.org>.
CONTEXT!!
On Wed, Apr 25, 2001 at 01:05:52PM -0400, Victor J. Orlikowski wrote:
> I believe so, Ben.
> If I understand the readbytes bit correctly, it is a pointer to a
> value containing the *amount* to read, where 0 is line-at-a-time.
>
> Victor
> --
> Victor J. Orlikowski
> ======================
> v.j.orlikowski@gte.net
> orlikowski@apache.org
> vjo@us.ibm.com
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by "Victor J. Orlikowski" <v....@gte.net>.
I believe so, Ben.
If I understand the readbytes bit correctly, it is a pointer to a
value containing the *amount* to read, where 0 is line-at-a-time.
Victor
--
Victor J. Orlikowski
======================
v.j.orlikowski@gte.net
orlikowski@apache.org
vjo@us.ibm.com
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by rb...@covalent.net.
> > orlikowski 01/04/23 19:50:19
> >
> > Modified: module-2.0 proxy_util.c
> > Log:
> > Just for the sake of cleanliness ...
>
> ??? this patch changes what is passed from NULL to the address of a
> variable set to zero - is that intended?
This is definately what was intended. The original code should have
caused a seg fault.
Ryan
> >
> > Revision Changes Path
> > 1.56 +2 -1 httpd-proxy/module-2.0/proxy_util.c
> >
> > Index: proxy_util.c
> > ===================================================================
> > RCS file: /home/cvs/httpd-proxy/module-2.0/proxy_util.c,v
> > retrieving revision 1.55
> > retrieving revision 1.56
> > diff -u -r1.55 -r1.56
> > --- proxy_util.c 2001/04/23 21:03:39 1.55
> > +++ proxy_util.c 2001/04/24 02:50:19 1.56
> > @@ -1087,6 +1087,7 @@
> > {
> > apr_bucket *e;
> > apr_status_t rv;
> > + apr_size_t zero = 0;
> > char *pos = buff;
> > char *response;
> > int found = 0;
> > @@ -1100,7 +1101,7 @@
> > while (!found) {
> >
> > /* get brigade from network one line at a time */
> > - if (APR_SUCCESS != (rv = ap_get_brigade(c->input_filters, bb, AP_MODE_BLOCKING, 0))) {
> > + if (APR_SUCCESS != (rv = ap_get_brigade(c->input_filters, bb, AP_MODE_BLOCKING, &zero))) {
> > return rv;
> > }
> >
> >
> >
> >
>
> --
> http://www.apache-ssl.org/ben.html
>
> "There is no limit to what a man can do or how far he can go if he
> doesn't mind who gets the credit." - Robert Woodruff
>
> ApacheCon 2001! http://ApacheCon.com/
>
>
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------
Re: cvs commit: httpd-proxy/module-2.0 proxy_util.c
Posted by rb...@covalent.net.
> > orlikowski 01/04/23 19:50:19
> >
> > Modified: module-2.0 proxy_util.c
> > Log:
> > Just for the sake of cleanliness ...
>
> ??? this patch changes what is passed from NULL to the address of a
> variable set to zero - is that intended?
This is definately what was intended. The original code should have
caused a seg fault.
Ryan
> >
> > Revision Changes Path
> > 1.56 +2 -1 httpd-proxy/module-2.0/proxy_util.c
> >
> > Index: proxy_util.c
> > ===================================================================
> > RCS file: /home/cvs/httpd-proxy/module-2.0/proxy_util.c,v
> > retrieving revision 1.55
> > retrieving revision 1.56
> > diff -u -r1.55 -r1.56
> > --- proxy_util.c 2001/04/23 21:03:39 1.55
> > +++ proxy_util.c 2001/04/24 02:50:19 1.56
> > @@ -1087,6 +1087,7 @@
> > {
> > apr_bucket *e;
> > apr_status_t rv;
> > + apr_size_t zero = 0;
> > char *pos = buff;
> > char *response;
> > int found = 0;
> > @@ -1100,7 +1101,7 @@
> > while (!found) {
> >
> > /* get brigade from network one line at a time */
> > - if (APR_SUCCESS != (rv = ap_get_brigade(c->input_filters, bb, AP_MODE_BLOCKING, 0))) {
> > + if (APR_SUCCESS != (rv = ap_get_brigade(c->input_filters, bb, AP_MODE_BLOCKING, &zero))) {
> > return rv;
> > }
> >
> >
> >
> >
>
> --
> http://www.apache-ssl.org/ben.html
>
> "There is no limit to what a man can do or how far he can go if he
> doesn't mind who gets the credit." - Robert Woodruff
>
> ApacheCon 2001! http://ApacheCon.com/
>
>
_______________________________________________________________________________
Ryan Bloom rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------