[jira] [Commented] (NIFI-4809) Implement a SiteToSiteMetricsReportingTask

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336458#comment-16336458 ] 

ASF GitHub Bot commented on NIFI-4809:
--------------------------------------

GitHub user pvillard31 opened a pull request:

    https://github.com/apache/nifi/pull/2430

    NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

    To avoid some code duplication, I moved few utilitary classes into the reporting-utils package. And I also added two metrics (available cores and load average) as we have in System Diagnostic but that we don't send with the current Ambari reporting task.
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pvillard31/nifi NIFI-4809

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2430.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2430
    
----
commit c49dd0e9ef08b34f30939b2771cd43bf580dc5d4
Author: Pierre Villard <pi...@...>
Date:   2018-01-23T22:15:18Z

    NIFI-4809 - Implement a SiteToSiteMetricsReportingTask

----


> Implement a SiteToSiteMetricsReportingTask
> ------------------------------------------
>
>                 Key: NIFI-4809
>                 URL: https://issues.apache.org/jira/browse/NIFI-4809
>             Project: Apache NiFi
>          Issue Type: New Feature
>          Components: Extensions
>            Reporter: Pierre Villard
>            Assignee: Pierre Villard
>            Priority: Major
>
> At the moment there is an AmbariReportingTask to send the NiFi-related metrics of the host to the Ambari Metrics Service. In a multi-cluster configuration, or when working with MiNiFi (Java) agents, it might not be possible for all the NiFi instances (NiFi and/or MiNiFi) to access the AMS REST API.
> To solve this problem, a solution would be to implement a SiteToSiteMetricsReportingTask to send the data via S2S to the "main" NiFi instance/cluster that will be able to publish the metrics into AMS (using InvokeHTTP). This way, it is possible to have the metrics of all the instances exposed in one AMS instance.
> I propose to send the data formatted as we are doing right now in the Ambari reporting task. If needed, it can be easily converted into another schema using the record processors once received via S2S.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)