You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "lyndsiWilliams (via GitHub)" <gi...@apache.org> on 2023/02/26 03:35:25 UTC
[GitHub] [superset] lyndsiWilliams opened a new pull request, #23203: test: Remove test playgrounds
lyndsiWilliams opened a new pull request, #23203:
URL: https://github.com/apache/superset/pull/23203
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
I found a couple of test playgrounds that were left in the code, this PR removes them.
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- cd into `superset-frontend`
- Run each test with these commands and observe no test playground in the terminal:
- `npm test superset-frontend/src/components/Datasource/DatasourceEditor.test.jsx`
- `npm test superset-frontend/src/dashboard/components/RefreshIntervalModal.test.tsx`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #23203: test: Remove test playgrounds
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #23203:
URL: https://github.com/apache/superset/pull/23203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23203: test: Remove test playgrounds
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23203:
URL: https://github.com/apache/superset/pull/23203#issuecomment-1445265479
# [Codecov](https://codecov.io/gh/apache/superset/pull/23203?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23203](https://codecov.io/gh/apache/superset/pull/23203?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (70f6df3) into [master](https://codecov.io/gh/apache/superset/commit/9e9f9dcae54564a461e451295289b2e6693df210?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e9f9dc) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 70f6df3 differs from pull request most recent head d493be4. Consider uploading reports for the commit d493be4 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23203 +/- ##
=======================================
Coverage 67.51% 67.51%
=======================================
Files 1900 1900
Lines 73318 73318
Branches 7935 7935
=======================================
Hits 49498 49498
Misses 21787 21787
Partials 2033 2033
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.69% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org