You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/06/12 12:48:00 UTC

[jira] [Commented] (AIRFLOW-4781) Added the ability to specify ports in kubernetesOperator

    [ https://issues.apache.org/jira/browse/AIRFLOW-4781?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862067#comment-16862067 ] 

ASF GitHub Bot commented on AIRFLOW-4781:
-----------------------------------------

rweverwijk commented on pull request #5410: [AIRFLOW-4781] Added the ability to specify ports in kubernetesOperator
URL: https://github.com/apache/airflow/pull/5410
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Added the ability to specify ports in kubernetesOperator
> --------------------------------------------------------
>
>                 Key: AIRFLOW-4781
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4781
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: operators
>    Affects Versions: 1.10.3
>            Reporter: Ron van Weverwijk
>            Assignee: Ron van Weverwijk
>            Priority: Minor
>             Fix For: 1.10.4, 2.0.0
>
>
> In kubernetes you have the ability to specify which ports to open to the container.
>  
> {code:java}
> containers:
>     - name: task-pv-container
>       image: nginx
>       ports:
>         - containerPort: 80
>           name: "http-server"
> {code}
> In this issue we want to add that support to the kubernetesOperator and `PodRequestFactory`
> With the support in the PodRequestFactory we can add functionality to build an operator that start a container in kubernetes and interact over the opened port.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)