[GitHub] john-bodley commented on a change in pull request #5449: [schema] Updating the tables schema

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #5449: [schema] Updating the tables schema
URL: https://github.com/apache/incubator-superset/pull/5449#discussion_r205641336
 
 

 ##########
 File path: superset/connectors/sqla/views.py
 ##########
 @@ -243,17 +244,13 @@ class TableModelView(DatasourceModelView, DeleteMixin, YamlExportMixin):  # noqa
         'is_sqllab_view': _('SQL Lab View'),
         'template_params': _('Template parameters'),
     }
+    validators_columns = {
 
 Review comment:
   @fabianmenges could you be more specific? It potentially seems wrong to use a period in a datasource name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org