You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "hhhizzz (via GitHub)" <gi...@apache.org> on 2026/05/18 08:29:38 UTC
[PR] Bump Trino to 481 and Paimon to 1.4.1 [paimon-trino]
hhhizzz opened a new pull request, #125:
URL: https://github.com/apache/paimon-trino/pull/125
## Summary
Bump the connector to Trino 481 and Paimon 1.4.1.
This also updates the connector code for Trino 481 SPI changes and Paimon 1.4.1 API changes, and fixes packaging/runtime compatibility issues found while testing Paimon table queries with Trino 481.
## Changes
- Upgrade Paimon dependencies to `1.4.1`.
- Adapt to Trino 481 connector SPI changes:
- return `SourcePage` from page sources
- implement connector shutdown hook
- update `NodeVersion` and filesystem module wiring
- adjust API usage affected by Trino 481 signature changes
- Adapt catalog and row handling for Paimon 1.4.1 APIs.
- Normalize Paimon table option property names to lower case before passing them to Paimon, fixing options such as `variant.shreddingSchema`.
- Update plugin packaging:
- copy Trino HDFS dependencies as jars for Trino 481
- include required Hive compatibility jars used by metastore/catalog paths
- Add focused tests for:
- Trino 481 page source compatibility
- Paimon table option normalization
- Do not include repo-local Maven settings under `.mvn`.
## Testing
```bash
mvn -Dtrino.version=481 -Dtest=TrinoPageSourceTest,TrinoTableOptionUtilsTest test
```
Result:
```text
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0
BUILD SUCCESS
```
```bash
mvn -Dtrino.version=481 -DskipTests package
```
Result:
```text
BUILD SUCCESS
```
Also validated the built plugin with Trino 481 against existing Paimon tables using count, grouped aggregation, CTE/join, window function, and self-join queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Trino to 481 and Paimon to 1.4.1 [paimon-trino]
Posted by "q8webmaster (via GitHub)" <gi...@apache.org>.
q8webmaster commented on PR #125:
URL: https://github.com/apache/paimon-trino/pull/125#issuecomment-4703605479
Tested this against Paimon 1.4.1 tables (Flink CDC writer, Parquet format) in a dev/staging environment. Built with:
mvn clean package -DskipTests \
-Dpaimon.version=1.4.1 \
-Dtrino.version=481 \
-Denforcer.skip=true
count, filtered selects, grouped aggregation, and joins all pass. No crashes or serialization errors.
It would be great to get this PR Merge soon. Thanks @hhhizzz !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Trino to 481 and Paimon to 1.4.1 [paimon-trino]
Posted by "hhhizzz (via GitHub)" <gi...@apache.org>.
hhhizzz commented on PR #125:
URL: https://github.com/apache/paimon-trino/pull/125#issuecomment-5036403823
> @hhhizzz Can you please update this PR to match latest versions of Trino 483 and Paimon 1.4.2?
will try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Trino to 481 and Paimon to 1.4.1 [paimon-trino]
Posted by "q8webmaster (via GitHub) via issues" <is...@paimon.apache.org>.
q8webmaster commented on PR #125:
URL: https://github.com/apache/paimon-trino/pull/125#issuecomment-6737633234
The deletion-vector bug from #129 is also in this branch. `TrinoPageSourceWrapper#getNextSourcePage()` still uses `getCompletedPositions()` as the page's start position. When a pushed-down filter makes the ORC reader skip row groups, filtered reads of ORC files with deletion vectors return wrong rows.
The fix in #130 targets `main`, but it also applies cleanly to this branch. I can open it as a PR against your branch if that's easier. Whichever PR merges first, the other only needs a small rebase in `TrinoPageSourceWrapper`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Trino to 481 and Paimon to 1.4.1 [paimon-trino]
Posted by "q8webmaster (via GitHub)" <gi...@apache.org>.
q8webmaster commented on PR #125:
URL: https://github.com/apache/paimon-trino/pull/125#issuecomment-5036371114
@hhhizzz Can you please update this PR to match latest versions of Trino 483 and Paimon 1.4.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump Trino to 481 and Paimon to 1.4.1 [paimon-trino]
Posted by "hhhizzz (via GitHub)" <gi...@apache.org>.
hhhizzz commented on PR #125:
URL: https://github.com/apache/paimon-trino/pull/125#issuecomment-5048578834
> > @hhhizzz Can you please update this PR to match latest versions of Trino 483 and Paimon 1.4.2?
>
> will try
https://github.com/apache/paimon-trino/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org