[jira] [Commented] (SOLR-15154) Let Http2SolrClient pass Basic Auth credentials to all requests

["Tomas Eduardo Fernandez Lobbe (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-15154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294205#comment-17294205 ] 

Tomas Eduardo Fernandez Lobbe commented on SOLR-15154:
------------------------------------------------------

Created a PR with the suggested changes. Note that it includes a new (optional) method in the {{Http2SolrClient.Builder}}:
{code:java}
public Builder withBasicAuthCredentials(String user, String pass)
{code}
Other {{HttpClientBuilderFactory}} are also supported (similar to HttpSolrClient}}, by passing a system property as we document in the ref guide.

> Let Http2SolrClient pass Basic Auth credentials to all requests
> ---------------------------------------------------------------
>
>                 Key: SOLR-15154
>                 URL: https://issues.apache.org/jira/browse/SOLR-15154
>             Project: Solr
>          Issue Type: Improvement
>          Components: SolrJ
>            Reporter: Tomas Eduardo Fernandez Lobbe
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In {{HttpSolrClient}}, one could specify credentials [at the JVM level|https://lucene.apache.org/solr/guide/8_8/basic-authentication-plugin.html#global-jvm-basic-auth-credentials], and that would make all requests to Solr have them. This doesn't work with the Http2 clients case and I think it's very useful. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org