You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by trixpan <gi...@git.apache.org> on 2016/09/23 16:37:36 UTC
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
GitHub user trixpan opened a pull request:
https://github.com/apache/nifi/pull/1057
NIFI-2816 - Clean typos across the code
part 1 of typo hunting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/trixpan/nifi typos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1057.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1057
----
commit 9e53a083fc5e29693f3b3953f925e4cb9b6c5bd3
Author: Andre F de Miranda <tr...@users.noreply.github.com>
Date: 2016-09-23T16:32:53Z
NIFI-2816 - Clean typos across the code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80344540
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/crypto/bcrypt/BCrypt.java ---
@@ -25,7 +25,7 @@
* This password hashing system tries to thwart off-line password
* cracking using a computationally-intensive hashing algorithm,
* based on Bruce Schneier's Blowfish cipher. The work factor of
- * the algorithm is parameterised, so it can be increased as
+ * the algorithm is parametrised, so it can be increased as
--- End diff --
addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1057
@bbende there's a few hundred more but I decided to split the task to avoid having to rebase non-stop! :sunglasses:
@joewitt pleased to help, next time the kangaroo steak bill is yours. :smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80344575
--- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/parser/BinaryReader.java ---
@@ -86,9 +86,9 @@ public int read() {
}
/**
- * Returns the byte that would be read without changing the posiiton
+ * Returns the byte that would be read without changing the positon
--- End diff --
addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1057
@bbende in that case, maybe the ``@Deprecated`` added in the code by @trixpan are not necessary. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1057
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80288347
--- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -164,7 +164,7 @@ public void commit() {
* {@link org.apache.nifi.processor.Processor#onTrigger} commits or rolls back the
* session
*/
- public void clearCommited() {
+ public void clearCommitted() {
--- End diff --
Is it a safe change?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1057
@pvillard31 note to myself: Never try to hunt typos after midnight ... :smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80344174
--- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java ---
@@ -164,7 +164,7 @@ public void commit() {
* {@link org.apache.nifi.processor.Processor#onTrigger} commits or rolls back the
* session
*/
- public void clearCommited() {
+ public void clearCommitted() {
--- End diff --
Good question. To be honest, I was relying on good old travis to tell.
Seems like it passes but yes, we are renaming a public method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1057
@pvillard31 I agree, lets remove the deprecated versions and just have the corrected versions, I'm a +1 after that change, and thanks to @trixpan for putting this together, didn't realize how many typos we had!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1057
yeah i def don't think we need deprecation notes for those. Should just be able to fix the typos.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80288233
--- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/parser/BinaryReader.java ---
@@ -86,9 +86,9 @@ public int read() {
}
/**
- * Returns the byte that would be read without changing the posiiton
+ * Returns the byte that would be read without changing the positon
*
- * @return the byte that would be read without changing the posiiton
+ * @return the byte that would be read without changing the positon
--- End diff --
position
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80344591
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ControllerConfigurationDTO.java ---
@@ -47,7 +47,7 @@ public void setMaxTimerDrivenThreadCount(Integer maxTimerDrivenThreadCount) {
* @return maximum number of event driven thread this NiFi has available
*/
@ApiModelProperty(
- value = "The maximum number of event driven threads the NiFi has avaiable."
+ value = "The maximum number of event driven threads the NiFi has avaliable."
--- End diff --
addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1057
Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80288960
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/crypto/bcrypt/BCrypt.java ---
@@ -25,7 +25,7 @@
* This password hashing system tries to thwart off-line password
* cracking using a computationally-intensive hashing algorithm,
* based on Bruce Schneier's Blowfish cipher. The work factor of
- * the algorithm is parameterised, so it can be increased as
+ * the algorithm is parametrised, so it can be increased as
--- End diff --
parametrized
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1057
@trixpan @pvillard31 since the three changes in question are not part of the public API we should be ok to change them as long as it is done on a second number version change (1.1.0 and not 1.0.1) which is what we are planning anyway, this should be consistent with our versioning/compatibility guide https://cwiki.apache.org/confluence/display/NIFI/Version+Scheme+and+API+Compatibility
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80288407
--- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ControllerConfigurationDTO.java ---
@@ -47,7 +47,7 @@ public void setMaxTimerDrivenThreadCount(Integer maxTimerDrivenThreadCount) {
* @return maximum number of event driven thread this NiFi has available
*/
@ApiModelProperty(
- value = "The maximum number of event driven threads the NiFi has avaiable."
+ value = "The maximum number of event driven threads the NiFi has avaliable."
--- End diff --
available
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80344580
--- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/parser/BinaryReader.java ---
@@ -86,9 +86,9 @@ public int read() {
}
/**
- * Returns the byte that would be read without changing the posiiton
+ * Returns the byte that would be read without changing the positon
*
- * @return the byte that would be read without changing the posiiton
+ * @return the byte that would be read without changing the positon
--- End diff --
addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1057
@joewitt , @bbende
suggestions? comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/1057
also @trixpan and reviewers: Thanks for doing this plus stale branch hunting. It is greatly appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1057
@pvillard31 I did a second sweep on this commit and the following public classes or methods have also been changed
org.apache.nifi.cluster.coordination.http.endpoints.ConnectionStatusEndpointMerger
org.apache.nifi.cluster.coordination.http.endpoints.DropRequestEndpointMerger;
What would be your suggesting? Rename the classes and public methods or leave them untouched?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1057
@trixpan, to be honest, about classes/methods renaming I'll concede to our PMC authority.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1057#discussion_r80288218
--- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/parser/BinaryReader.java ---
@@ -86,9 +86,9 @@ public int read() {
}
/**
- * Returns the byte that would be read without changing the posiiton
+ * Returns the byte that would be read without changing the positon
--- End diff --
position
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---