You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "SkyeYoung (via GitHub)" <gi...@apache.org> on 2025/05/23 02:25:41 UTC
[PR] fix(workflow): scheduled test [apisix-dashboard]
SkyeYoung opened a new pull request, #3077:
URL: https://github.com/apache/apisix-dashboard/pull/3077
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
Testing workflow cannot be triggered normally due to lack of conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow): scheduled test [apisix-dashboard]
Posted by "SkyeYoung (via GitHub)" <gi...@apache.org>.
SkyeYoung merged PR #3077:
URL: https://github.com/apache/apisix-dashboard/pull/3077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(workflow): scheduled test [apisix-dashboard]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #3077:
URL: https://github.com/apache/apisix-dashboard/pull/3077#discussion_r2103680013
##########
.github/workflows/e2e.yml:
##########
@@ -15,7 +15,8 @@ concurrency:
jobs:
test:
- if: ${{ contains(github.event.pull_request.labels.*.name, 'e2e-test') }}
+ # only run when e2e-test label is added or scheduled
+ if: ${{ contains(github.event.pull_request.labels.*.name, 'e2e-test') || github.event_name == 'schedule' }}
Review Comment:
When the event is scheduled, the 'pull_request' object might not be present, which could lead to a runtime error. Consider adding a safeguard or restructuring the condition to handle scheduled events without relying on pull_request attributes.
```suggestion
if: ${{ (github.event_name == 'pull_request' && contains(github.event.pull_request.labels.*.name, 'e2e-test')) || github.event_name == 'schedule' }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org