You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by ij...@apache.org on 2016/05/13 11:10:19 UTC
kafka git commit: KAFKA-3692;
Add quotes to variables in kafka-run-class.sh
Repository: kafka
Updated Branches:
refs/heads/trunk f34164eed -> fb421dbcf
KAFKA-3692; Add quotes to variables in kafka-run-class.sh
Author: Liquan Pei <li...@gmail.com>
Reviewers: Geoff Anderson <ge...@confluent.io>, Jun Rao <ju...@gmail.com>, Ismael Juma <is...@juma.me.uk>
Closes #1364 from Ishiihara/add-quote-classpath
Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/fb421dbc
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/fb421dbc
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/fb421dbc
Branch: refs/heads/trunk
Commit: fb421dbcfe36c4a0d9df7a742c18c11515f095c5
Parents: f34164e
Author: Liquan Pei <li...@gmail.com>
Authored: Fri May 13 12:10:09 2016 +0100
Committer: Ismael Juma <is...@juma.me.uk>
Committed: Fri May 13 12:10:09 2016 +0100
----------------------------------------------------------------------
bin/kafka-run-class.sh | 50 ++++++++++++++++++++++-----------------------
1 file changed, 25 insertions(+), 25 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kafka/blob/fb421dbc/bin/kafka-run-class.sh
----------------------------------------------------------------------
diff --git a/bin/kafka-run-class.sh b/bin/kafka-run-class.sh
index 688cced..76d0b88 100755
--- a/bin/kafka-run-class.sh
+++ b/bin/kafka-run-class.sh
@@ -50,85 +50,85 @@ fi
# run ./gradlew copyDependantLibs to get all dependant jars in a local dir
shopt -s nullglob
-for dir in $base_dir/core/build/dependant-libs-${SCALA_VERSION}*;
+for dir in "$base_dir"/core/build/dependant-libs-${SCALA_VERSION}*;
do
- if [ -z $CLASSPATH ] ; then
- CLASSPATH=$dir/*
+ if [ -z "$CLASSPATH" ] ; then
+ CLASSPATH="$dir/*"
else
- CLASSPATH=$CLASSPATH:$dir/*
+ CLASSPATH="$CLASSPATH:$dir/*"
fi
done
-for file in $base_dir/examples/build/libs/kafka-examples*.jar;
+for file in "$base_dir"/examples/build/libs/kafka-examples*.jar;
do
if should_include_file "$file"; then
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
fi
done
-for file in $base_dir/clients/build/libs/kafka-clients*.jar;
+for file in "$base_dir"/clients/build/libs/kafka-clients*.jar;
do
if should_include_file "$file"; then
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
fi
done
-for file in $base_dir/streams/build/libs/kafka-streams*.jar;
+for file in "$base_dir"/streams/build/libs/kafka-streams*.jar;
do
if should_include_file "$file"; then
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
fi
done
-for file in $base_dir/streams/examples/build/libs/kafka-streams-examples*.jar;
+for file in "$base_dir"/streams/examples/build/libs/kafka-streams-examples*.jar;
do
if should_include_file "$file"; then
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
fi
done
-for file in $base_dir/streams/build/dependant-libs-${SCALA_VERSION}/rocksdb*.jar;
+for file in "$base_dir"/streams/build/dependant-libs-${SCALA_VERSION}/rocksdb*.jar;
do
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
done
-for file in $base_dir/tools/build/libs/kafka-tools*.jar;
+for file in "$base_dir"/tools/build/libs/kafka-tools*.jar;
do
if should_include_file "$file"; then
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
fi
done
-for dir in $base_dir/tools/build/dependant-libs-${SCALA_VERSION}*;
+for dir in "$base_dir"/tools/build/dependant-libs-${SCALA_VERSION}*;
do
- CLASSPATH=$CLASSPATH:$dir/*
+ CLASSPATH="$CLASSPATH:$dir/*"
done
for cc_pkg in "api" "runtime" "file" "json" "tools"
do
- for file in $base_dir/connect/${cc_pkg}/build/libs/connect-${cc_pkg}*.jar;
+ for file in "$base_dir"/connect/${cc_pkg}/build/libs/connect-${cc_pkg}*.jar;
do
if should_include_file "$file"; then
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
fi
done
if [ -d "$base_dir/connect/${cc_pkg}/build/dependant-libs" ] ; then
- CLASSPATH=$CLASSPATH:$base_dir/connect/${cc_pkg}/build/dependant-libs/*
+ CLASSPATH="$CLASSPATH:$base_dir/connect/${cc_pkg}/build/dependant-libs/*"
fi
done
# classpath addition for release
-for file in $base_dir/libs/*;
+for file in "$base_dir"/libs/*;
do
if should_include_file "$file"; then
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
fi
done
-for file in $base_dir/core/build/libs/kafka_${SCALA_BINARY_VERSION}*.jar;
+for file in "$base_dir"/core/build/libs/kafka_${SCALA_BINARY_VERSION}*.jar;
do
if should_include_file "$file"; then
- CLASSPATH=$CLASSPATH:$file
+ CLASSPATH="$CLASSPATH":"$file"
fi
done
shopt -u nullglob