You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/04/23 12:49:19 UTC
[GitHub] [incubator-nuttx] v01d opened a new issue #2163: sim: terminal is garbled when nuttx is killed
v01d opened a new issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163
If you kill nuttx sim binary (even with SIGTERM), the terminal is garbled. Probably something needs to be done in some exit/signal handler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-808230415
> It would seem so, but I'm confused as to why that PR fixes it. As you mentioned before, there was cleanup required to be done on sim exit.
Since the PR doesn't disable OPOST, \n will always translate to \r\n.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
v01d commented on issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-808215923
It would seem so, but I'm confused as to why that PR fixes it. As you mentioned before, there was cleanup required to be done on sim exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 closed issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-719138624
This is because sim use atexit to restore the state:
https://github.com/apache/incubator-nuttx/blob/master/arch/sim/src/sim/up_simuart.c#L112
https://github.com/apache/incubator-nuttx/blob/master/arch/sim/src/sim/up_x11framebuffer.c#L262
which need change to signal handler, but I guess x11 can restore automatically without the special action.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
v01d commented on issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-808238472
Ah, I understand: it was garbled due to changing this bit from default. I assume other changes do not require any undoing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
v01d commented on issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-825134016
I think that this needs further work since I find now that CTRL+C does not work anymore when nuttx is killed. The cleanest would probably be to get the flags before sim starts and then reapply them in the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-825352740
Yes, the input process is turned off, we need to find a reliable way to restore it. #2998 just fix the output:(.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-808210057
Should be fixed by: https://github.com/apache/incubator-nuttx/pull/2998. @v01d please try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] v01d commented on issue #2163: sim: terminal is garbled when nuttx is killed
Posted by GitBox <gi...@apache.org>.
v01d commented on issue #2163:
URL: https://github.com/apache/incubator-nuttx/issues/2163#issuecomment-825635216
I'll reopen for tracking
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org