You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "123123213weqw (via GitHub)" <gi...@apache.org> on 2026/08/02 01:43:16 UTC

[PR] fix(studio): make DLQ provider fail explicitly instead of returning stub data [rocketmq-dashboard]

123123213weqw opened a new pull request, #750:
URL: https://github.com/apache/rocketmq-dashboard/pull/750

   Fixes #686
   
   ### Problem
   
   `DLQProviderStub` is wired as the production `DLQProvider`, but it:
   - returns **hard-coded sample DLQ groups** from `listDLQGroups`, and
   - treats `resendMessages` as a **no-op** (only logs, never resends).
   
   Returning sample data and successful no-op responses can mislead operators into believing real DLQ groups exist and that resend requests actually succeeded.
   
   ### Fix
   
   Until a real DLQ provider is connected, both operations now **fail explicitly** with a structured `501 Not Implemented` `BusinessException` (which `GlobalExceptionHandler` maps to a clean `Result.error(501, ...)` response), as the issue's "Expected" section calls for. The hard-coded stub data and its helper methods are removed.
   
   `DLQProviderStubTest` is updated to assert the new not-implemented behavior.
   
   ### Verification
   
   `mvn test -Dtest=DLQProviderStubTest` passes on JDK 21: `Tests run: 3, Failures: 0, Errors: 0, Skipped: 0`.
   
   ### Diff
   
   2 files changed, +28 / -85.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(studio): make DLQ provider fail explicitly instead of returning stub data [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins commented on PR #750:
URL: https://github.com/apache/rocketmq-dashboard/pull/750#issuecomment-5161743561

   Thanks for the contribution. This is already covered by #687, merged into `rocketmq-studio` as 31cb026: the hard-coded stub DLQ groups are gone and `listDLQGroups` / `resendMessages` now throw `BusinessException(501, "DLQ provider is not configured")`, with `DLQProviderStubTest` rewritten to assert that. #687 was opened first, so it was merged under first-come-first-served review order.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(studio): make DLQ provider fail explicitly instead of returning stub data [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #750: fix(studio): make DLQ provider fail explicitly instead of returning stub data
URL: https://github.com/apache/rocketmq-dashboard/pull/750


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org