You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2018/05/10 23:50:43 UTC

[GitHub] storm pull request #2639: STORM-3035: fix the issue in JmsSpout.ack when toC...

Github user HeartSaVioR commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2639#discussion_r187484768
  
    --- Diff: external/storm-jms/src/main/java/org/apache/storm/jms/spout/JmsSpout.java ---
    @@ -18,164 +18,124 @@
     
     package org.apache.storm.jms.spout;
     
    -import java.io.Serializable;
    -import java.util.HashMap;
    -import java.util.Map;
    -import java.util.Timer;
    -import java.util.TimerTask;
    -import java.util.TreeSet;
    -import java.util.concurrent.LinkedBlockingQueue;
    -import java.util.concurrent.TimeUnit;
    -import javax.jms.Connection;
    -import javax.jms.ConnectionFactory;
    -import javax.jms.Destination;
    -import javax.jms.JMSException;
    -import javax.jms.Message;
    -import javax.jms.MessageConsumer;
    -import javax.jms.MessageListener;
    -import javax.jms.Session;
    -import org.apache.storm.Config;
     import org.apache.storm.jms.JmsProvider;
     import org.apache.storm.jms.JmsTupleProducer;
     import org.apache.storm.spout.SpoutOutputCollector;
     import org.apache.storm.task.TopologyContext;
     import org.apache.storm.topology.OutputFieldsDeclarer;
     import org.apache.storm.topology.base.BaseRichSpout;
     import org.apache.storm.tuple.Values;
    -import org.apache.storm.utils.Utils;
     import org.slf4j.Logger;
     import org.slf4j.LoggerFactory;
     
    +import javax.jms.Connection;
    --- End diff --
    
    Reorganizing imports happens now, and it looks like one of checkstyle violation.


---