You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2021/04/21 19:45:05 UTC
[GitHub] [unomi] atompie opened a new pull request #300: Unomi 1.5.x
atompie opened a new pull request #300:
URL: https://github.com/apache/unomi/pull/300
PR Title format:
[UNOMI-469] Actions that add value to profile property
Action that add and remove value from property list. Existing actions do not remove values. Adding is also throwing errors when there is a type conflict that means property list consists integers and we add strings.
With this plugin we want to deliver a set of basic actions to use within TRACARDI User Interface for Unomi.
https://github.com/atompie/tracardi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on a change in pull request #300: [UNOMI-469] + [UNOMI-470] Actions that add, remove value to profile property, ncrementing, Decrementing profile property
Posted by GitBox <gi...@apache.org>.
sergehuber commented on a change in pull request #300:
URL: https://github.com/apache/unomi/pull/300#discussion_r618109960
##########
File path: plugins/pom.xml
##########
@@ -39,6 +39,7 @@
<module>past-event</module>
<module>tracked-event</module>
<module>kafka-injector</module>
+ <module>tracardi-plugins</module>
Review comment:
I would prefer we do not add a "client" specific plugin here. Rather these actions, if we keep them (see below), should become part of the base plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] atompie commented on pull request #300: [UNOMI-469] + [UNOMI-470] Actions that add, remove value to profile property, ncrementing, Decrementing profile property
Posted by GitBox <gi...@apache.org>.
atompie commented on pull request #300:
URL: https://github.com/apache/unomi/pull/300#issuecomment-855303859
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] jkevan commented on pull request #300: [UNOMI-469] + [UNOMI-470] Actions that add, remove value to profile property, ncrementing, Decrementing profile property
Posted by GitBox <gi...@apache.org>.
jkevan commented on pull request #300:
URL: https://github.com/apache/unomi/pull/300#issuecomment-851475111
Ok no problem,
Are you ok if we close this pull request ?
In the future we will probably implement this features like we describe, but it's currently not our priority.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on pull request #300: [UNOMI-469] + [UNOMI-470] Actions that add, remove value to profile property, ncrementing, Decrementing profile property
Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #300:
URL: https://github.com/apache/unomi/pull/300#issuecomment-855858947
Closing as approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] atompie commented on pull request #300: [UNOMI-469] + [UNOMI-470] Actions that add, remove value to profile property, ncrementing, Decrementing profile property
Posted by GitBox <gi...@apache.org>.
atompie commented on pull request #300:
URL: https://github.com/apache/unomi/pull/300#issuecomment-850502495
Unfortunately I am lacking time recently working on the GUI. So can't work on this at this time. If you would like to continue with changes to this PR please take over :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber commented on pull request #300: [UNOMI-469] + [UNOMI-470] Actions that add, remove value to profile property, ncrementing, Decrementing profile property
Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #300:
URL: https://github.com/apache/unomi/pull/300#issuecomment-824831066
Also I think it would be interesting to sort of regroup the IncrementPropertyAction with some of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [unomi] sergehuber closed pull request #300: [UNOMI-469] + [UNOMI-470] Actions that add, remove value to profile property, ncrementing, Decrementing profile property
Posted by GitBox <gi...@apache.org>.
sergehuber closed pull request #300:
URL: https://github.com/apache/unomi/pull/300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org