You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/17 04:01:23 UTC
[GitHub] codecov-io commented on issue #5023: [sqllab] force limit queries
only when there is no existing limit
codecov-io commented on issue #5023: [sqllab] force limit queries only when there is no existing limit
URL: https://github.com/apache/incubator-superset/pull/5023#issuecomment-389737583
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=h1) Report
> Merging [#5023](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5a64b3f57747d7b9328d4a5f84afe8f7b21b069b?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `85.71%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5023/graphs/tree.svg?src=pr&token=KsB0fHcx6l&width=650&height=150)](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5023 +/- ##
==========================================
+ Coverage 77.34% 77.35% +0.01%
==========================================
Files 44 44
Lines 8665 8678 +13
==========================================
+ Hits 6702 6713 +11
- Misses 1963 1965 +2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.66% <ø> (ø)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `75.54% <100%> (+0.26%)` | :arrow_up: |
| [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `87.76% <81.81%> (-0.15%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=footer). Last update [5a64b3f...71ca5cc](https://codecov.io/gh/apache/incubator-superset/pull/5023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org