[GitHub] [buildstream] gtristan commented on pull request #1680: Use `StageTree` to stage previous sources

[GitBox <gi...@apache.org>]

gtristan commented on PR #1680:
URL: https://github.com/apache/buildstream/pull/1680#issuecomment-1186130168

   I concur that this should not be blocked because certain configurations of `buildbox` are not necessarily tested.
   
   > However, as we currently only test with buildbox-fuse, it may make sense to consider all other configurations unsupported. I.e. add a buildbox-fuse check to BuildStream initialization and fail if it is not available. When we properly support environments without buildbox-fuse (with CI and safeguard in place to ensure the setup can't corrupt the cache), we can lift the buildbox-fuse requirement.
   
   I don't think I like saying that *"BuildStream does not support this Buildbox setup"* as a statement from the BuildStream front.
   
   I rather think: *"BuildStream uses Buildbox"* and from BuildStream's perspective, it is Buildbox's job to function correctly as an abstraction layer for execution on varoius platforms (I think that was the idea).
   
   In one sense, it would be nice for BuildStream to have CI for as many variant setups as possible so that we can find and report issues to other upstream projects we depend on, but in another sense; I feel that *how* buildbox works is buildbox's problem and not BuildStream's.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org