Re: [PR] Core: Add `view-override` catalog property [iceberg]

["ebyhr (via GitHub)" <gi...@apache.org>]

ebyhr commented on code in PR #12534:
URL: https://github.com/apache/iceberg/pull/12534#discussion_r1998215522


##########
core/src/test/java/org/apache/iceberg/inmemory/TestInMemoryViewCatalog.java:
##########
@@ -35,6 +35,9 @@ public void before() {
         ImmutableMap.<String, String>builder()
             .put(CatalogProperties.VIEW_DEFAULT_PREFIX + "key1", "catalog-default-key1")
             .put(CatalogProperties.VIEW_DEFAULT_PREFIX + "key2", "catalog-default-key2")
+            .put(CatalogProperties.VIEW_DEFAULT_PREFIX + "key3", "catalog-default-key3")

Review Comment:
   I added this line to verify the behavior when we specified a property with both default (L38) and override (L39) properties. I can remove this line if it's unnecessary. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org