You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@avalon.apache.org by do...@apache.org on 2002/05/12 09:24:21 UTC
cvs commit: jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection DefaultConnectionManager.java
donaldp 02/05/12 00:24:21
Modified: src/java/org/apache/avalon/cornerstone/blocks/connection
DefaultConnectionManager.java
Log:
Update block to be Servicable rather than Composable.
Revision Changes Path
1.14 +7 -7 jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection/DefaultConnectionManager.java
Index: DefaultConnectionManager.java
===================================================================
RCS file: /home/cvs/jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection/DefaultConnectionManager.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- DefaultConnectionManager.java 16 Mar 2002 00:18:33 -0000 1.13
+++ DefaultConnectionManager.java 12 May 2002 07:24:21 -0000 1.14
@@ -14,10 +14,10 @@
import org.apache.avalon.cornerstone.services.threads.ThreadManager;
import org.apache.avalon.excalibur.thread.ThreadPool;
import org.apache.avalon.framework.activity.Disposable;
-import org.apache.avalon.framework.component.ComponentException;
-import org.apache.avalon.framework.component.ComponentManager;
-import org.apache.avalon.framework.component.Composable;
import org.apache.avalon.framework.logger.AbstractLogEnabled;
+import org.apache.avalon.framework.service.ServiceException;
+import org.apache.avalon.framework.service.ServiceManager;
+import org.apache.avalon.framework.service.Serviceable;
import org.apache.avalon.phoenix.Block;
/**
@@ -30,7 +30,7 @@
*/
public class DefaultConnectionManager
extends AbstractLogEnabled
- implements Block, ConnectionManager, Composable, Disposable
+ implements Block, ConnectionManager, Serviceable, Disposable
{
private HashMap m_connections = new HashMap();
private ThreadManager m_threadManager;
@@ -38,10 +38,10 @@
/**
* @phoenix:dependency name="org.apache.avalon.cornerstone.services.threads.ThreadManager"
*/
- public void compose( final ComponentManager componentManager )
- throws ComponentException
+ public void service( final ServiceManager serviceManager )
+ throws ServiceException
{
- m_threadManager = (ThreadManager)componentManager.lookup( ThreadManager.ROLE );
+ m_threadManager = (ThreadManager)serviceManager.lookup( ThreadManager.ROLE );
}
public void dispose()
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection
DefaultConnectionManager.java
Posted by Paul Hammant <Pa...@yahoo.com>.
Peter,
>BTW it seems one of your tools generates junk comments for methods (basically
>saying I am a class, I am a method) or inheriting comments from method you
>implement/overide. Would it be possible to turn this off ? :)
>
>
JIndent? OK I'll turn it off.
- Paul
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection DefaultConnectionManager.java
Posted by Peter Donald <pe...@apache.org>.
BTW it seems one of your tools generates junk comments for methods (basically
saying I am a class, I am a method) or inheriting comments from method you
implement/overide. Would it be possible to turn this off ? :)
--
Cheers,
Peter Donald
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection DefaultConnectionManager.java
Posted by Peter Donald <pe...@apache.org>.
On Sun, 12 May 2002 17:53, Paul Hammant wrote:
> Peter,
>
> > public class DefaultConnectionManager
> > extends AbstractLogEnabled
> > - implements Block, ConnectionManager, Composable, Disposable
> > + implements Block, ConnectionManager, Serviceable, Disposable
>
> Is this a general recommendation for blocks that were Composable ?
+1
Definetly!
--
Cheers,
Peter Donald
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-avalon-cornerstone/src/java/org/apache/avalon/cornerstone/blocks/connection
DefaultConnectionManager.java
Posted by Paul Hammant <Pa...@yahoo.com>.
Peter,
> public class DefaultConnectionManager
> extends AbstractLogEnabled
> - implements Block, ConnectionManager, Composable, Disposable
> + implements Block, ConnectionManager, Serviceable, Disposable
>
>
Is this a general recommendation for blocks that were Composable ?
- Paul
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>