You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "gerlowskija (via GitHub)" <gi...@apache.org> on 2023/04/16 19:44:03 UTC

[GitHub] [solr] gerlowskija commented on pull request #1453: SOLR-16391: Migrate collection creating APIs to JAX-RS

gerlowskija commented on PR #1453:
URL: https://github.com/apache/solr/pull/1453#issuecomment-1510470263

   Towards the end of last week, I was able to add the "restore collection" API to this PR, which is the last of the "collection-creating" APIs I'd hoped to do in this PR.
   
   In hindsight though, it's grown a little larger than I was expecting and I'm a little leery of merging as is: both for the onerous-ness of review, and because the size would make any test-noise harder to pinpoint.
   
   To this end, I filed a PR this morning that gives the create-collection, create-alias, and restore-collection v2 APIs their own (unique) REST-ful paths.  Splitting them up to be on different paths removes the blocker I mentioned [in my previous comment](https://github.com/apache/solr/pull/1453#issuecomment-1466671301), and will allow me to split this PR into 3 separate PRs (one for each API).  I'll aim to merge those individually, and close this PR without merging.
   
   The first of these single-API PRs, for create-collection, can be found [here](https://github.com/apache/solr/pull/1453#issuecomment-1466671301).  Hoping to have single-API PRs for Create-Alias and Restore shortly as well!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org