[GitHub] seelmann commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors

[GitBox <gi...@apache.org>]

seelmann commented on issue #3596: [AIRFLOW-2747] Explicit re-schedule of sensors
URL: https://github.com/apache/incubator-airflow/pull/3596#issuecomment-447596460
 
 
   @ashb I can work on those during the holidays.
   
   Regarding 1 (the "None" state): I agree it's not optimal that there is not indication about what's going on. Do you want to have a new dedicated state (in state.py)? Or is is just about the visualization in the tree view (and other views make also sense IMHO)? Adding a new state was discussed but decided against. Changing the visualization in views should be possible, in Gantt view it's already done.
   
   Regarding 2 (the success log): What do you expect should be logged instead of success? If I look into `sequential_executor.py` it always returns sets success or failed, depending if the command execution was successful or not. Should we make all executors aware of the reschedule state?
   
   PS: We run 1.10.0 with this patch successfully in production since November :)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services