You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/01/22 01:00:02 UTC

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22365


Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................

IMPALA-13683: Add env var to skip infra tests and verifiers.

bin/run-all-tests.sh provides a convenient way to repeat running the
same test multiple times by setting NUM_TEST_ITERATIONS env var. This is
especially useful to prove that a test is not flaky. However, it will
still redundantly repeat infra tests and verifiers without any way to
skip them.

This patch adds env var INFRA_TEST and VERIFIERS_TEST to allow skipping
them. The default values for them are true (do not skip).

Testing:
Manually run the script with both INFRA_TEST and VERIFIERS_TEST set to
false and confirm that both are skipped.

Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
---
M bin/run-all-tests.sh
M tests/run-tests.py
2 files changed, 24 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/22365/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18104/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 00:34:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22365

to look at the new patch set (#5).

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................

IMPALA-13683: Add env var to skip infra tests and verifiers.

bin/run-all-tests.sh provides a convenient way to repeat running the
same test multiple times by setting NUM_TEST_ITERATIONS env var. This is
especially useful to prove that a test is not flaky. However, it will
still redundantly repeat run-workload.py and verifiers without any way
to skip them.

This patch adds env var SKIP_VERIFIERS to allow skipping verifiers. "Run
test run-workload" is rewitten into its own test_run_workload.py.

Testing:
- Run and pass test_run_workload.py.
- Manually run the script with SKIP_VERIFIERS set to true and confirm
  that verifiers are skipped.

Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
---
M bin/run-all-tests.sh
A tests/infra/test_run_workload.py
M tests/run-tests.py
3 files changed, 73 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/22365/5
-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22365/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/22365/2/bin/run-all-tests.sh@283
PS2, Line 283:     # Run some queries using run-workload to verify run-workload has not been broken.
             :     if ! run-step "Run test run-workload" test-run-workload.log \
             :         "${IMPALA_HOME}/bin/run-workload.py" -w tpch --num_clients=2 \
             :         --query_names=TPCH-Q1 --table_format=text/none \
             :         --exec_options="disable_codegen:False" ${KERB_ARGS}; then
             :       TEST_RET_CODE=1
             :     fi
> Not required for this review:
Ack. Let me try that.



-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jan 2025 23:28:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 12:13:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 5: Code-Review+2

(1 comment)

Thanks, this is looking good to me

http://gerrit.cloudera.org:8080/#/c/22365/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22365/5//COMMIT_MSG@16
PS5, Line 16: rewitten
Nit: rewritten



-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 00:20:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 6: Code-Review+2

(1 comment)

Thank you, Joe!
Carry +2.

http://gerrit.cloudera.org:8080/#/c/22365/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/22365/2/bin/run-all-tests.sh@283
PS2, Line 283:     # JdbcTest) queries against an impala cluster.
             :     pushd "${IMPALA_FE_DIR}"
             : 
             :     # Add Jamm as javaagent for CatalogdMetaProviderTest.testWeights
             :     JAMM_JAR=$(compgen -G ${IMPALA_HOME}/fe/target/dependency/jamm-*.jar)
             :     export JAVA_TOOL_OPTIONS="${JAVA_TOOL_OPTIONS-} -javaagent:${JAMM_JAR}"
             : 
> Ack. Let me try that.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 00:46:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11374/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 00:47:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

This is making sense to me

I would consider naming VERIFIERS_TEST as SKIP_VERIFIERS.

http://gerrit.cloudera.org:8080/#/c/22365/2/bin/run-all-tests.sh
File bin/run-all-tests.sh:

http://gerrit.cloudera.org:8080/#/c/22365/2/bin/run-all-tests.sh@283
PS2, Line 283:     # Run some queries using run-workload to verify run-workload has not been broken.
             :     if ! run-step "Run test run-workload" test-run-workload.log \
             :         "${IMPALA_HOME}/bin/run-workload.py" -w tpch --num_clients=2 \
             :         --query_names=TPCH-Q1 --table_format=text/none \
             :         --exec_options="disable_codegen:False" ${KERB_ARGS}; then
             :       TEST_RET_CODE=1
             :     fi
Not required for this review:

We could think about turning this into a regular ee test. It looks like we already have the tests/infra directory.



-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Jan 2025 22:57:34 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18105/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 00:35:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22365

to look at the new patch set (#6).

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................

IMPALA-13683: Add env var to skip infra tests and verifiers.

bin/run-all-tests.sh provides a convenient way to repeat running the
same test multiple times by setting NUM_TEST_ITERATIONS env var. This is
especially useful to prove that a test is not flaky. However, it will
still redundantly repeat run-workload.py and verifiers without any way
to skip them.

This patch adds env var SKIP_VERIFIERS to allow skipping verifiers. "Run
test run-workload" is rewritten into its own test_run_workload.py.

Testing:
- Run and pass test_run_workload.py.
- Manually run the script with SKIP_VERIFIERS set to true and confirm
  that verifiers are skipped.

Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
---
M bin/run-all-tests.sh
A tests/infra/test_run_workload.py
M tests/run-tests.py
3 files changed, 73 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/22365/6
-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 00:47:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11374/


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 06:24:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11375/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 06:45:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22365

to look at the new patch set (#4).

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................

IMPALA-13683: Add env var to skip infra tests and verifiers.

bin/run-all-tests.sh provides a convenient way to repeat running the
same test multiple times by setting NUM_TEST_ITERATIONS env var. This is
especially useful to prove that a test is not flaky. However, it will
still redundantly repeat run-workload.py and verifiers without any way
to skip them.

This patch adds env var SKIP_VERIFIERS to allow skipping verifiers. "Run
test run-workload" is rewitten into its own test_run_workload.py.

Testing:
- Run and pass test_run_workload.py.
- Manually run the script with SKIP_VERIFIERS set to true and confirm
  that verifiers are skipped.

Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
---
M bin/run-all-tests.sh
A tests/infra/test_run_workload.py
M tests/run-tests.py
3 files changed, 74 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/22365/4
-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18103/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 00:30:20 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/18045/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Jan 2025 01:26:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................


Patch Set 7:

> Patch Set 7: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11374/

Hit flaky testPartitionFileMetadataAfterMinorCompaction. Will try rerun one more time.


-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Jan 2025 06:45:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22365

to look at the new patch set (#3).

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................

IMPALA-13683: Add env var to skip infra tests and verifiers.

bin/run-all-tests.sh provides a convenient way to repeat running the
same test multiple times by setting NUM_TEST_ITERATIONS env var. This is
especially useful to prove that a test is not flaky. However, it will
still redundantly repeat run-workload.py and verifiers without any way
to skip them.

This patch adds env var SKIP_VERIFIERS to allow skipping verifiers. "Run
test run-workload" is rewitten into its own test_run_workload.py.

Testing:
- Run and pass test_run_workload.py.
- Manually run the script with SKIP_VERIFIERS set to true and confirm
  that verifiers are skipped.

Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
---
M bin/run-all-tests.sh
A tests/infra/test_run_workload.py
M tests/run-tests.py
3 files changed, 73 insertions(+), 13 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/22365/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13683: Add env var to skip infra tests and verifiers.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22365 )

Change subject: IMPALA-13683: Add env var to skip infra tests and verifiers.
......................................................................

IMPALA-13683: Add env var to skip infra tests and verifiers.

bin/run-all-tests.sh provides a convenient way to repeat running the
same test multiple times by setting NUM_TEST_ITERATIONS env var. This is
especially useful to prove that a test is not flaky. However, it will
still redundantly repeat run-workload.py and verifiers without any way
to skip them.

This patch adds env var SKIP_VERIFIERS to allow skipping verifiers. "Run
test run-workload" is rewritten into its own test_run_workload.py.

Testing:
- Run and pass test_run_workload.py.
- Manually run the script with SKIP_VERIFIERS set to true and confirm
  that verifiers are skipped.

Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Reviewed-on: http://gerrit.cloudera.org:8080/22365
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
A tests/infra/test_run_workload.py
M tests/run-tests.py
3 files changed, 73 insertions(+), 13 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib483dcd48980655e4aa0c77f1cdc1f2a3c40a1de
Gerrit-Change-Number: 22365
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>