[GitHub] [jackrabbit-oak] klcodanr commented on a change in pull request #513: OAK-9717 - Prevent Merge from Removing nodes

[GitBox <gi...@apache.org>]

klcodanr commented on a change in pull request #513:
URL: https://github.com/apache/jackrabbit-oak/pull/513#discussion_r823721253



##########
File path: oak-run/src/main/java/org/apache/jackrabbit/oak/index/merge/IndexDefMergerUtils.java
##########
@@ -148,6 +148,8 @@ private static String mergeProperty(String path, String property, JsonObject anc
             return cp;
         } else if (Objects.equals(ap, cp)) {
             return pp;
+        } else if (ap == null) {
+            return cp;

Review comment:
       My thought is that if the custom index defined the _same_ property name with a different value as is now in the product index, but that property was not present before, that we should preserve that custom value as the developer of the custom index would expect their customizations to be preserved not undone.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org