You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/02/25 12:01:47 UTC

[GitHub] [iotdb] SteveYurongSu opened a new pull request #2738: [IOTDB-1177] Trigger module: ANTLR, logical operators, physical plans and authorization 

SteveYurongSu opened a new pull request #2738:
URL: https://github.com/apache/iotdb/pull/2738


   It is the entrance to the trigger management module, and should mainly contain the following parts of code:
   1. Trigger management SQL (ANTLR, logical operators, physical plans and corresponding execution interfaces)
   2. User authentication for trigger management


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #2738: [IOTDB-1177] Trigger module: ANTLR, logical operators, physical plans and authorization

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #2738:
URL: https://github.com/apache/iotdb/pull/2738#discussion_r584410740



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/constant/SQLConstant.java
##########
@@ -170,7 +170,13 @@ private SQLConstant() {
   public static final int TOK_QUERY_PROCESSLIST = 97;
   public static final int TOK_KILL_QUERY = 98;
 
-  public static final int TOK_CHILD_NODES = 99;

Review comment:
       Thank you all. I'll keep TOK_CHILD_NODES = 99.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SilverNarcissus commented on a change in pull request #2738: [IOTDB-1177] Trigger module: ANTLR, logical operators, physical plans and authorization

Posted by GitBox <gi...@apache.org>.
SilverNarcissus commented on a change in pull request #2738:
URL: https://github.com/apache/iotdb/pull/2738#discussion_r584397328



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/constant/SQLConstant.java
##########
@@ -170,7 +170,13 @@ private SQLConstant() {
   public static final int TOK_QUERY_PROCESSLIST = 97;
   public static final int TOK_KILL_QUERY = 98;
 
-  public static final int TOK_CHILD_NODES = 99;

Review comment:
       You change it from 99 to 104, may this cause wal inconsistent problem? More specifically if token 99 has written into wal and I update the IoTDB, may this cause a problem?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on pull request #2738: [IOTDB-1177] Trigger module: ANTLR, logical operators, physical plans and authorization

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #2738:
URL: https://github.com/apache/iotdb/pull/2738#issuecomment-787588335


   Thanks for reviewing @HTHou @SilverNarcissus . I will add some UTs.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #2738: [IOTDB-1177] Trigger module: ANTLR, logical operators, physical plans and authorization

Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #2738:
URL: https://github.com/apache/iotdb/pull/2738#discussion_r584407291



##########
File path: server/src/main/java/org/apache/iotdb/db/qp/constant/SQLConstant.java
##########
@@ -170,7 +170,13 @@ private SQLConstant() {
   public static final int TOK_QUERY_PROCESSLIST = 97;
   public static final int TOK_KILL_QUERY = 98;
 
-  public static final int TOK_CHILD_NODES = 99;

Review comment:
       TOK_CHILD_NODES was added into master two days ago. So I don't think it's a big problem.
   But it's still better to keep TOK_CHILD_NODES = 99.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on pull request #2738: [IOTDB-1177] Trigger module: ANTLR, logical operators, physical plans and authorization

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #2738:
URL: https://github.com/apache/iotdb/pull/2738#issuecomment-787755659


   > Hi, I think it's better to add some explanation about the reason of hiding user guide for now..
   
   Added. :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #2738: [IOTDB-1177] Trigger module: ANTLR, logical operators, physical plans and authorization

Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #2738:
URL: https://github.com/apache/iotdb/pull/2738


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on pull request #2738: [IOTDB-1177] Trigger module: ANTLR, logical operators, physical plans and authorization

Posted by GitBox <gi...@apache.org>.
HTHou commented on pull request #2738:
URL: https://github.com/apache/iotdb/pull/2738#issuecomment-787736405


   Hi, I think it's better to add some explanation about the reason of hiding user guide for now.. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org