[GitHub] [spark] tgravescs commented on a change in pull request #27943: [SPARK-31179] Fast fail the connection while last connection failed in fast fail time window

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #27943: [SPARK-31179] Fast fail the connection while last connection failed in fast fail time window
URL: https://github.com/apache/spark/pull/27943#discussion_r401667407
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/network/netty/NettyBlockTransferService.scala
 ##########
 @@ -119,7 +119,7 @@ private[spark] class NettyBlockTransferService(
         override def createAndStart(blockIds: Array[String],
             listener: BlockFetchingListener): Unit = {
           try {
-            val client = clientFactory.createClient(host, port)
+            val client = clientFactory.createClient(host, port, true)
 
 Review comment:
   this is being passed in all the time even when the maxRetries is 0.  change the parameter to be based on:
   if (maxRetries > 0) true else false

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org