You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jlprat (via GitHub)" <gi...@apache.org> on 2024/07/15 06:55:02 UTC
[PR] Backport kafka admin client bug [kafka]
jlprat opened a new pull request, #16593:
URL: https://github.com/apache/kafka/pull/16593
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Backport kafka admin client bug [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16593:
URL: https://github.com/apache/kafka/pull/16593#issuecomment-2227911975
OK, I'll do this @mimaison . I'll use this PR just to prove the CI and then cherry-pick them individually on 3.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Backport kafka admin client bug [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat closed pull request #16593: Backport kafka admin client bug
URL: https://github.com/apache/kafka/pull/16593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Backport kafka admin client bug [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16593:
URL: https://github.com/apache/kafka/pull/16593#issuecomment-2228447033
Test failures unrelated. Cherry-picking individually to `3.8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Backport kafka admin client bug [kafka]
Posted by "jlprat (via GitHub)" <gi...@apache.org>.
jlprat commented on PR #16593:
URL: https://github.com/apache/kafka/pull/16593#issuecomment-2227822377
Hi @mimaison and @chia7712. The backport fixing the bug you encountered in RC0, in case you want to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Backport kafka admin client bug [kafka]
Posted by "mimaison (via GitHub)" <gi...@apache.org>.
mimaison commented on PR #16593:
URL: https://github.com/apache/kafka/pull/16593#issuecomment-2227908854
Thanks @jlprat !
Instead of putting both commits in a single PR, I'd prefer if you cherry-picked both on 3.8 directly (IIRC both cherry-pick cleanly and you can still use this PR to ensure the tests pass). Otherwise they'll get squashed and it will be harder to reason what commits this contains in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org