[jira] [Closed] (OFBIZ-7344) db connections remain open and unused on startup

["Jacques Le Roux (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-7344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jacques Le Roux closed OFBIZ-7344.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 15.12.01
                   14.12.01

Thanks Gareth,

I was unable to "see a new connection is created for your selected group" when running "Check/Update database from webtools". But I tested with Postgres while and after discussing with you about this. I can confirm it works. After a review it's obvious that, when the connection is null, a finally for closing the new created connection was needed.

Your patch is in
trunk r1748543  
R15.12  r1748544
R14.12  r1748545
R13.07 since this is not a biggie and it's hard to backport by hand I let him as is



> db connections remain open and unused on startup
> ------------------------------------------------
>
>                 Key: OFBIZ-7344
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-7344
>             Project: OFBiz
>          Issue Type: Bug
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Gareth Carter
>            Assignee: Jacques Le Roux
>            Priority: Minor
>             Fix For: 14.12.01, 15.12.01
>
>         Attachments: DatabaseUtil.patch
>
>
> When ofbiz starts and checks the database, it will leave open connections and will not get reused.
> If you run Check/Update database from webtools, you can see a new connection is created for your selected group
> As far as I can tell, the problem lies in DatabaseUtil.getDatabaseMetaData. If the parameter connection is null, a new connection object is created but not closed (like any resource should be!)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)