You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/02/13 09:02:26 UTC

[GitHub] [buildstream] juergbi commented on a change in pull request #1591: Stop running CI for distro versions with Python 3.6

juergbi commented on a change in pull request #1591:
URL: https://github.com/apache/buildstream/pull/1591#discussion_r805303196



##########
File path: .github/compose/ci.docker-compose.yml
##########
@@ -34,14 +34,6 @@ services:
     <<: *tests-template
     image: registry.gitlab.com/buildstream/buildstream-docker-images/testsuite-debian:10-${CI_IMAGE_VERSION:-latest}
 
-  ubuntu-18.04:
-    <<: *tests-template
-    image: registry.gitlab.com/buildstream/buildstream-docker-images/testsuite-ubuntu:18.04-${CI_IMAGE_VERSION:-latest}
-

Review comment:
       The most important aspect, in my opinion, is that we keep testing Python 3.7 in CI. We can't but also shouldn't have to test all distro/Python combination. I think it's preferable to test distros with their default Python 3 version as that's more likely what people actually use.
   
   Python 3.7 is already covered by Debian 10, which is expected to get LTS support until June 2024, which is after the Python 3.7 EOL date (June 2023). While there is a Python 3.7 package for Ubuntu 18.04, it's not the default version and it's in the 'universe' archive, which means that it's not guaranteed to be supported by Canonical, as far as I can tell. We now have a Ubuntu 20.04 (Python 3.8) Docker image for master, which we could also use for 1.x.
   
   CentOS 7.7 (1908) is no longer supported. We could upgrade to the still supported CentOS 7.9 (2009) and install Python 3.8 from the software collection. However, I'd like to drop CentOS 7 from the Docker images for BuildStream master to lower maintenance cost and image build time. This means that we'd have to maintain a separate branch of bst-docker-images for 1.x. In my opinion, it would make more sense to upgrade to CentOS Stream 8 with Python 3.8 or 3.9, which would be useful for both 1.x and master.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org