[GitHub] dgrove-oss commented on a change in pull request #4082: Rename prewarmed containers

[GitBox <gi...@apache.org>]

dgrove-oss commented on a change in pull request #4082: Rename prewarmed containers
URL: https://github.com/apache/incubator-openwhisk/pull/4082#discussion_r229847820
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesContainer.scala
 ##########
 @@ -138,4 +139,9 @@ class KubernetesContainer(protected[core] val id: ContainerId,
       .takeWithin(waitForLogs)
       .map { _.toByteString }
   }
+
+  /** Rename container. */
+  override def rename(name: String)(implicit transid: TransactionId): Future[Unit] =
+    // rename currently not supported
+    Future.successful(Unit)
 
 Review comment:
   Would be easy enough to implement rename by making a call to change the value of the `name` label of the container.  However, this will add some latency, so as above we should decide if we can do it asynchronously and ignore any errors or synchronously so errors can be cleanly detected and handled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services