[GitHub] [logging-log4j2] sman-81 edited a comment on pull request #544: LOG4J2-3115: Remember previously computed strings in NamePatternConverter for performance ~3x

[GitBox <gi...@apache.org>]

sman-81 edited a comment on pull request #544:
URL: https://github.com/apache/logging-log4j2/pull/544#issuecomment-893394475


   Hi again @carterkozak interesting what you've found. Thanks for looking into this.
   Your research puts a question mark behind the usefulness of my pull request.
   My benchmarks were with a single thread only.
   In practice, is this code executed in multiple log4j2 threads?
   
   My use case is millions of log records from the same logger (records that must be persisted for compliance reasons).
   Ideally the abbreviated name of such a logger should be created once not millions of times, was my thought.
   A cache (as exists in my PR) may not be the best solution.
   The abbreviated name could be stored in the logger itself (all abbreviated names by pattern, to be precise), however this would require substantial architectural changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org