You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/10/18 15:20:19 UTC
[PR] Fix nullable SQL normalization in projection matching [shardingsphere]
terrymanu opened a new pull request, #40226:
URL: https://github.com/apache/shardingsphere/pull/40226
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix nullable SQL normalization in projection matching [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #40226:
URL: https://github.com/apache/shardingsphere/pull/40226#issuecomment-6251607419
### Result
Review Result: Mergeable
No blocking issues or recommended changes remain.
### Evidence
The original SQLUtils method bodies remain unchanged.
Null text is rejected before a derived projection is created.
Relevant tests and style checks passed.
### Coverage
Reviewed the local task delta against baseline 30820c7d44f9.
Covered SQLUtils, ProjectionsContextEngine, and their corresponding tests:
4 files and 18 changed blocks.
Reviewed root causes, affected contracts, tests, and execution paths against
the approved nullable contract and implementation scope.
Both independent assessments agreed after coordinator reconciliation and
session validation. No unresolved evidence gaps remain.
This conclusion covers code correctness only; CI was not reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix nullable SQL normalization in projection matching [shardingsphere]
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #40226:
URL: https://github.com/apache/shardingsphere/pull/40226
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org