You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/03 16:33:23 UTC
[GitHub] [incubator-seatunnel] TaoZex opened a new pull request, #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
TaoZex opened a new pull request, #3856:
URL: https://github.com/apache/incubator-seatunnel/pull/3856
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
reference https://github.com/apache/incubator-seatunnel/pull/3719
Change Doris Config Prefix
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #3856:
URL: https://github.com/apache/incubator-seatunnel/pull/3856#discussion_r1061246681
##########
docs/en/connector-v2/sink/Doris.md:
##########
@@ -75,11 +75,9 @@ Using as a multiplier for generating the next delay for backoff
The amount of time to wait before attempting to retry a request to `Doris`
-### sink.properties.* [doris stream load config]
+### doris.config [map]
Review Comment:
Can you add more instructions about this option? For example where can users find these parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex closed pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
Posted by GitBox <gi...@apache.org>.
TaoZex closed pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
URL: https://github.com/apache/incubator-seatunnel/pull/3856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on a diff in pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
Posted by GitBox <gi...@apache.org>.
TaoZex commented on code in PR #3856:
URL: https://github.com/apache/incubator-seatunnel/pull/3856#discussion_r1061255891
##########
docs/en/connector-v2/sink/Doris.md:
##########
@@ -75,11 +75,9 @@ Using as a multiplier for generating the next delay for backoff
The amount of time to wait before attempting to retry a request to `Doris`
-### sink.properties.* [doris stream load config]
+### doris.config [map]
Review Comment:
Thanks，I added the stream load official doc link.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3856:
URL: https://github.com/apache/incubator-seatunnel/pull/3856#issuecomment-1370563911
@Hisoka-X PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] hailin0 merged pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
Posted by GitBox <gi...@apache.org>.
hailin0 merged PR #3856:
URL: https://github.com/apache/incubator-seatunnel/pull/3856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex closed pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
Posted by GitBox <gi...@apache.org>.
TaoZex closed pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
URL: https://github.com/apache/incubator-seatunnel/pull/3856
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
Posted by GitBox <gi...@apache.org>.
TaoZex commented on PR #3856:
URL: https://github.com/apache/incubator-seatunnel/pull/3856#issuecomment-1370882983
> Hi, put this change to doris e2e module, thanks.
ok，I have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3856: [Improve][Connector-V2][Doris] Change Doris Config Prefix
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on PR #3856:
URL: https://github.com/apache/incubator-seatunnel/pull/3856#issuecomment-1370766359
Hi, put this change to doris e2e module, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org