You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/01/20 22:44:04 UTC
[GitHub] [nifi] thenatog opened a new pull request #5694: NIFI-5402 - Disable the tar.gz build artifact by default. Build will …
thenatog opened a new pull request #5694:
URL: https://github.com/apache/nifi/pull/5694
…only generate a .zip unless specifying the maven profile -Pbuild-tar-gz
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on pull request #5694: NIFI-5402 - Disable the tar.gz build artifact by default. Build will …
Posted by GitBox <gi...@apache.org>.
greyp9 commented on pull request #5694:
URL: https://github.com/apache/nifi/pull/5694#issuecomment-1035545459
> @greyp9 Updated, should cover most of the issues you saw.
Thanks. The first two cases seem to work as expected now, but the `dir-only` case is emitting the same seven zips. This was probably wrong before this PR. Should we address that in a follow up ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #5694: NIFI-5402 - Disable the tar.gz build artifact by default. Build will …
Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #5694:
URL: https://github.com/apache/nifi/pull/5694#issuecomment-1033071300
@greyp9 Updated, should cover most of the issues you saw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] joewitt commented on pull request #5694: NIFI-5402 - Disable the tar.gz build artifact by default. Build will …
Posted by GitBox <gi...@apache.org>.
joewitt commented on pull request #5694:
URL: https://github.com/apache/nifi/pull/5694#issuecomment-1017993781
I'd just call it 'targz' to be consistent with teh 'rpm' profile that follows right after. Can we please take care of all assemblies at once? There are a lot of tar.gz/zip pairs as default convenience artifacts so lets just tackle them in one if you dont mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #5694: NIFI-5402 - Disable the tar.gz build artifact by default. Build will …
Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #5694:
URL: https://github.com/apache/nifi/pull/5694#issuecomment-1036397101
I guess the dir-only profile was intended for the main NiFi assembly ./nifi-assembly/target/nifi-1.16.0-SNAPSHOT-bin.zip, as it seems like it's missing in a few places. I will add it in for the other assemblies, it seems like registry would be the main other one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] thenatog commented on pull request #5694: NIFI-5402 - Disable the tar.gz build artifact by default. Build will …
Posted by GitBox <gi...@apache.org>.
thenatog commented on pull request #5694:
URL: https://github.com/apache/nifi/pull/5694#issuecomment-1018204238
Updated to build with the -Ptargz profile and added the profile to other assembly poms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on pull request #5694: NIFI-5402 - Disable the tar.gz build artifact by default. Build will …
Posted by GitBox <gi...@apache.org>.
greyp9 commented on pull request #5694:
URL: https://github.com/apache/nifi/pull/5694#issuecomment-1027483745
The extra XML in the module descriptors seems to make sense, but after running a set of builds, it looks like we're not getting the right output.
```
nifi % mvn clean install -DskipTests
...
nifi % find . -name "*bin.zip"
./nifi-assembly/target/nifi-1.16.0-SNAPSHOT-bin.zip
./nifi-toolkit/nifi-toolkit-assembly/target/nifi-toolkit-1.16.0-SNAPSHOT-bin.zip
./minifi/minifi-c2/minifi-c2-assembly/target/minifi-c2-1.16.0-SNAPSHOT-bin.zip
./minifi/minifi-toolkit/minifi-toolkit-assembly/target/minifi-toolkit-1.16.0-SNAPSHOT-bin.zip
./minifi/minifi-assembly/target/minifi-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-toolkit/nifi-registry-toolkit-assembly/target/nifi-registry-toolkit-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-extensions/nifi-registry-aws/nifi-registry-aws-assembly/target/nifi-registry-aws-assembly-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-extensions/nifi-registry-ranger/nifi-registry-ranger-assembly/target/nifi-registry-ranger-assembly-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-assembly/target/nifi-registry-1.16.0-SNAPSHOT-bin.zip
./nifi-stateless/nifi-stateless-assembly/target/nifi-stateless-1.16.0-SNAPSHOT-bin.zip
nifi % find . -name "*bin.tar.gz"
nifi %
nifi % mvn clean install -DskipTests -P targz
...
nifi % find . -name "*bin.zip"
./nifi-registry/nifi-registry-extensions/nifi-registry-aws/nifi-registry-aws-assembly/target/nifi-registry-aws-assembly-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-extensions/nifi-registry-ranger/nifi-registry-ranger-assembly/target/nifi-registry-ranger-assembly-1.16.0-SNAPSHOT-bin.zip
nifi % find . -name "*bin.tar.gz"
./nifi-assembly/target/nifi-1.16.0-SNAPSHOT-bin.tar.gz
./nifi-toolkit/nifi-toolkit-assembly/target/nifi-toolkit-1.16.0-SNAPSHOT-bin.tar.gz
./minifi/minifi-c2/minifi-c2-assembly/target/minifi-c2-1.16.0-SNAPSHOT-bin.tar.gz
./minifi/minifi-toolkit/minifi-toolkit-assembly/target/minifi-toolkit-1.16.0-SNAPSHOT-bin.tar.gz
./minifi/minifi-assembly/target/minifi-1.16.0-SNAPSHOT-bin.tar.gz
./nifi-registry/nifi-registry-toolkit/nifi-registry-toolkit-assembly/target/nifi-registry-toolkit-1.16.0-SNAPSHOT-bin.tar.gz
./nifi-registry/nifi-registry-assembly/target/nifi-registry-1.16.0-SNAPSHOT-bin.tar.gz
./nifi-stateless/nifi-stateless-assembly/target/nifi-stateless-1.16.0-SNAPSHOT-bin.tar.gz
nifi %
nifi % mvn clean install -DskipTests -Ddir-only
...
nifi % find . -name "*bin.zip"
./nifi-toolkit/nifi-toolkit-assembly/target/nifi-toolkit-1.16.0-SNAPSHOT-bin.zip
./minifi/minifi-c2/minifi-c2-assembly/target/minifi-c2-1.16.0-SNAPSHOT-bin.zip
./minifi/minifi-toolkit/minifi-toolkit-assembly/target/minifi-toolkit-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-toolkit/nifi-registry-toolkit-assembly/target/nifi-registry-toolkit-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-extensions/nifi-registry-aws/nifi-registry-aws-assembly/target/nifi-registry-aws-assembly-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-extensions/nifi-registry-ranger/nifi-registry-ranger-assembly/target/nifi-registry-ranger-assembly-1.16.0-SNAPSHOT-bin.zip
./nifi-registry/nifi-registry-assembly/target/nifi-registry-1.16.0-SNAPSHOT-bin.zip
nifi % find . -name "*bin.tar.gz"
nifi %
```
I would expect the default build to emit ten zips, the `targz` profile to emit ten tgzs, and the "dir-only" switch to suppress the assembly of any instance of either. Is this test set correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org