You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by "wangnimaa (GitHub)" <gi...@apache.org> on 2018/11/02 08:18:48 UTC

[GitHub] [incubator-dubbo] wangnimaa opened pull request #2730: code format

## What is the purpose of the change

XXXXX

## Brief changelog

XXXXX

## Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2730 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] codecov-io commented on issue #2730: code format

Posted by "codecov-io (GitHub)" <gi...@apache.org>.

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2730?src=pr&el=h1) Report
> Merging [#2730](https://codecov.io/gh/apache/incubator-dubbo/pull/2730?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/3cf801bb9d45524ae1e4692e04aeda2bcb5050dd?src=pr&el=desc) will **increase** coverage by `1.1%`.
> The diff coverage is `0%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2730?src=pr&el=tree)

```diff
@@            Coverage Diff            @@
##           master    #2730     +/-   ##
=========================================
+ Coverage   62.35%   63.46%   +1.1%     
=========================================
  Files         602      580     -22     
  Lines       27978    25984   -1994     
  Branches     4831     4543    -288     
=========================================
- Hits        17446    16490    -956     
+ Misses       8259     7321    -938     
+ Partials     2273     2173    -100
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2730?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...c/main/java/com/alibaba/dubbo/monitor/Monitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL21vbml0b3IvTW9uaXRvci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [.../src/main/java/com/alibaba/dubbo/rpc/Exporter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9FeHBvcnRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...main/java/org/apache/dubbo/rpc/AsyncRpcResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9Bc3luY1JwY1Jlc3VsdC5qYXZh) | `32.75% <ø> (ø)` | :arrow_up: |
| [...ain/java/com/alibaba/dubbo/rpc/cluster/Router.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL1JvdXRlci5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...le/src/main/java/com/alibaba/dubbo/rpc/Filter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9GaWx0ZXIuamF2YQ==) | `100% <ø> (ø)` | :arrow_up: |
| [...in/java/org/apache/dubbo/rpc/AsyncContextImpl.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9Bc3luY0NvbnRleHRJbXBsLmphdmE=) | `53.84% <ø> (ø)` | :arrow_up: |
| [...main/java/org/apache/dubbo/rpc/AbstractResult.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9BYnN0cmFjdFJlc3VsdC5qYXZh) | `44.44% <ø> (ø)` | :arrow_up: |
| [...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9JbnZvY2F0aW9uLmphdmE=) | `50% <ø> (ø)` | :arrow_up: |
| [.../java/com/alibaba/dubbo/rpc/cluster/Directory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL0RpcmVjdG9yeS5qYXZh) | `0% <ø> (ø)` | :arrow_up: |
| [...main/java/com/alibaba/dubbo/registry/Registry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlZ2lzdHJ5L1JlZ2lzdHJ5LmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| ... and [38 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2730/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2730?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2730?src=pr&el=footer). Last update [3cf801b...353de93](https://codecov.io/gh/apache/incubator-dubbo/pull/2730?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2730 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [incubator-dubbo] beiwei30 closed pull request #2730: code format

Posted by "beiwei30 (GitHub)" <gi...@apache.org>.

[ pull request closed by beiwei30 ]

[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2730 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org