You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/30 07:31:11 UTC

[GitHub] [incubator-superset] ktmud commented on a change in pull request #10368: docs: Add supported database logos

ktmud commented on a change in pull request #10368:
URL: https://github.com/apache/incubator-superset/pull/10368#discussion_r462512644



##########
File path: README.md
##########
@@ -91,11 +91,35 @@ Superset provides:
 * Fast loading dashboards with configurable caching
 
 
-## Database Support
+## Supported Databases
 
 Superset speaks many SQL dialects through SQLAlchemy - a Python
-SQL toolkit that is compatible with most databases. A list of
-supported databases can be found
+SQL toolkit that is compatible with most databases. Here are some of the major database solutions that are supported:
+
+<p float="left">

Review comment:
       ```suggestion
   <p align="center">
   ```
   
   This is totally optional, but do you think aligning images to the center would make them look better?
   
   ### Before
   
   ![image](https://user-images.githubusercontent.com/335541/88840337-289c0c80-d191-11ea-83e6-d065afb52933.png)
   
   ### After
   
   ![image](https://user-images.githubusercontent.com/335541/88840301-1c17b400-d191-11ea-8459-b8751d6f0206.png)
   
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org